Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 723823002: AudioBufferSourceNode loop duration should be the actual duration (Closed)

Created:
6 years, 1 month ago by Raymond Toy
Modified:
5 years, 10 months ago
CC:
blink-reviews, Raymond Toy
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

AudioBufferSourceNode loop duration should be the actual duration When an AudioBufferSourceNode is looping and the user calls start(when, offset, duration), the source should play the loop as if the user called start(when, offset) followed by stop(when+duration). This means there may be many repetitions of the loop if the duration is long. See also the discussion in https://github.com/WebAudio/web-audio-api/issues/421 BUG=430991 TESTS=audiobuffersource-start,audiobuffersource-loop-comprehensive Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189563

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : One item per line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -22 lines) Patch
M LayoutTests/webaudio/audiobuffersource-loop-comprehensive.html View 1 2 3 4 2 chunks +94 lines, -19 lines 0 comments Download
M LayoutTests/webaudio/audiobuffersource-loop-comprehensive-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webaudio/audiobuffersource-start.html View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/webaudio/audiobuffersource-start-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webaudio/resources/audiobuffersource-testing.js View 2 chunks +24 lines, -1 line 0 comments Download
M Source/modules/webaudio/AudioBufferSourceNode.cpp View 1 2 3 4 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Raymond Toy
PTAL.
5 years, 10 months ago (2015-02-03 19:20:41 UTC) #2
hongchan
lgtm https://codereview.chromium.org/723823002/diff/60001/LayoutTests/webaudio/audiobuffersource-loop-comprehensive.html File LayoutTests/webaudio/audiobuffersource-loop-comprehensive.html (right): https://codereview.chromium.org/723823002/diff/60001/LayoutTests/webaudio/audiobuffersource-loop-comprehensive.html#newcode97 LayoutTests/webaudio/audiobuffersource-loop-comprehensive.html:97: I understand there are so many objects and ...
5 years, 10 months ago (2015-02-03 23:09:05 UTC) #3
Raymond Toy
https://codereview.chromium.org/723823002/diff/60001/LayoutTests/webaudio/audiobuffersource-loop-comprehensive.html File LayoutTests/webaudio/audiobuffersource-loop-comprehensive.html (right): https://codereview.chromium.org/723823002/diff/60001/LayoutTests/webaudio/audiobuffersource-loop-comprehensive.html#newcode97 LayoutTests/webaudio/audiobuffersource-loop-comprehensive.html:97: On 2015/02/03 23:09:05, hoch wrote: > I understand there ...
5 years, 10 months ago (2015-02-04 00:18:06 UTC) #5
Raymond Toy
PTAL.
5 years, 10 months ago (2015-02-04 19:07:45 UTC) #7
Ken Russell (switch to Gerrit)
lgtm
5 years, 10 months ago (2015-02-04 19:48:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723823002/80001
5 years, 10 months ago (2015-02-04 20:52:10 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 15:20:41 UTC) #11
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189563

Powered by Google App Engine
This is Rietveld 408576698