Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 723793002: Add "envoy" GYP variable for pulling in envoy targets. (Closed)

Created:
6 years, 1 month ago by Daniel Erat
Modified:
6 years, 1 month ago
Reviewers:
James Cook
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add "envoy" GYP variable for pulling in envoy targets. BUG=426914 Committed: https://crrev.com/77f15bd8cb64ab8b997b6aa7a26f5ff5d1afa0f4 Cr-Commit-Position: refs/heads/master@{#303928}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M build/all.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M build/common.gypi View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Daniel Erat
6 years, 1 month ago (2014-11-12 22:28:09 UTC) #2
James Cook
LGTM
6 years, 1 month ago (2014-11-12 22:28:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723793002/1
6 years, 1 month ago (2014-11-12 22:31:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-13 00:04:23 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 00:05:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77f15bd8cb64ab8b997b6aa7a26f5ff5d1afa0f4
Cr-Commit-Position: refs/heads/master@{#303928}

Powered by Google App Engine
This is Rietveld 408576698