Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 723773002: Bring back ScriptDebugServer and associated machinery (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
Reviewers:
yurys, abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Bring back ScriptDebugServer and associated machinery Eventually all of this should be moved out of Sky and instead sit on top of Sky as just a mojo v8 debug service but for now I'm just bringing back what we had in Blink so I can make it work with our new inspector backend and then we can move it out. I also sorted gn lists and fixed two .idl files which were in the wrong sources list in core.gni. R=abarth@chromium.org, yurys@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c2d13a9a01cc287b476ee0f479ed961175fdbe0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13617 lines, -133 lines) Patch
M sky/README.md View 1 chunk +5 lines, -0 lines 0 comments Download
M sky/engine/bindings/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/bindings/core/idl.gni View 1 chunk +0 lines, -3 lines 0 comments Download
A sky/engine/bindings/core/v8/ScriptDebugServer.h View 1 chunk +167 lines, -0 lines 0 comments Download
A sky/engine/bindings/core/v8/ScriptDebugServer.cpp View 1 chunk +715 lines, -0 lines 0 comments Download
A sky/engine/bindings/core/v8/custom/V8JavaScriptCallFrameCustom.cpp View 1 chunk +81 lines, -0 lines 0 comments Download
M sky/engine/bindings/core/v8/custom/custom.gypi View 2 chunks +3 lines, -2 lines 0 comments Download
M sky/engine/bindings/core/v8/v8.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/engine/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/core.gni View 11 chunks +30 lines, -27 lines 0 comments Download
A sky/engine/core/inspector/BUILD.gn View 1 chunk +48 lines, -0 lines 0 comments Download
A sky/engine/core/inspector/CodeGeneratorInspector.py View 1 chunk +2364 lines, -0 lines 0 comments Download
A sky/engine/core/inspector/CodeGeneratorInspectorStrings.py View 1 chunk +963 lines, -0 lines 0 comments Download
A sky/engine/core/inspector/Inspector-1.1.json View 1 chunk +3981 lines, -0 lines 0 comments Download
A sky/engine/core/inspector/JavaScriptCallFrame.h View 1 chunk +90 lines, -0 lines 0 comments Download
A sky/engine/core/inspector/JavaScriptCallFrame.cpp View 1 chunk +215 lines, -0 lines 0 comments Download
A + sky/engine/core/inspector/JavaScriptCallFrame.idl View 1 chunk +31 lines, -37 lines 0 comments Download
A + sky/engine/core/inspector/ScriptBreakpoint.h View 2 chunks +21 lines, -22 lines 0 comments Download
A + sky/engine/core/inspector/ScriptDebugListener.h View 2 chunks +50 lines, -42 lines 0 comments Download
A sky/engine/core/inspector/generate-inspector-protocol-version View 1 chunk +476 lines, -0 lines 0 comments Download
A sky/engine/core/inspector/protocol.json View 1 chunk +4372 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
6 years, 1 month ago (2014-11-12 22:03:38 UTC) #1
abarth-chromium
LGTM rs=me
6 years, 1 month ago (2014-11-12 22:20:58 UTC) #2
eseidel
6 years, 1 month ago (2014-11-12 22:21:48 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c2d13a9a01cc287b476ee0f479ed961175fdbe0a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698