Issue 723633003: Reland ScreenOrientationDelegate on ChromeOS

Issue 723633003: Reland ScreenOrientationDelegate on ChromeOS (Closed)

Created:
6 years, 1 month ago by jonross

Modified:
6 years, 1 month ago

Reviewers:
flackr, Avi (use Gerrit), oshima, Rick Byers, mlamouri (slow - plz ping)

CC:
chromium-reviews, kalyank, jam, sadrul, darin-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Reland ScreenOrientationDelegate on ChromeOS This change fixes the error in: https://codereview.chromium.org/648733003 This reverts commit 61aaa96a45aaa556a96ee19b87f0e512129a27d7. TBR=avi@chromium.org, oshima@chromium.org, rbyers@chromium.org, mlamouri@chromium.org BUG=396760 Committed: https://crrev.com/f21fea1f360c6d41348673093ff784ed494cacf2 Cr-Commit-Position: refs/heads/master@{#303952}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+487 lines, -10 lines)			Patch
M	ash/ash.gyp	View		3 chunks	+4 lines, -0 lines	0 comments	Download
A	ash/content/display/DEPS	View		1 chunk	+13 lines, -0 lines	0 comments	Download
A	ash/content/display/screen_orientation_delegate_chromeos.h	View		1 chunk	+64 lines, -0 lines	0 comments	Download
A	ash/content/display/screen_orientation_delegate_chromeos.cc	View	1	1 chunk	+180 lines, -0 lines	0 comments	Download
A	ash/content/display/screen_orientation_delegate_chromeos_unittest.cc	View		1 chunk	+194 lines, -0 lines	0 comments	Download
M	ash/shell.h	View		3 chunks	+8 lines, -0 lines	0 comments	Download
M	ash/shell.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	ash/wm/maximize_mode/maximize_mode_controller.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	ash/wm/maximize_mode/maximize_mode_controller.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/browser/screen_orientation/screen_orientation_delegate_android.h	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	content/browser/screen_orientation/screen_orientation_delegate_android.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	content/public/browser/screen_orientation_delegate.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/public/browser/screen_orientation_provider.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

jonross

Hey Rob, Could you review this fix for a break of the compilation of Chrome ...

6 years, 1 month ago (2014-11-13 00:27:39 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723633003/20001

6 years, 1 month ago (2014-11-13 00:31:26 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-13 01:23:37 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/f21fea1f360c6d41348673093ff784ed494cacf2
Cr-Commit-Position: refs/heads/master@{#303952}