Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 723623003: Revert of [DevTools] Move SystemInfo domain to generated handler (Closed)

Created:
6 years, 1 month ago by ernstm
Modified:
6 years, 1 month ago
Reviewers:
vkuzkokov, dgozman, jbauman
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@browserProtocol
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Move SystemInfo domain to generated handler (patchset #5 id:120001 of https://codereview.chromium.org/665123002/) Reason for revert: This probably brok the WinXP perf bots: http://build.chromium.org/p/chromium.perf/builders/Win%20XP%20Perf%20%284%29/builds/801 Speculatively reverting. Original issue's description: > [DevTools] Move SystemInfo domain to generated handler > > BUG=405566 > > Committed: https://crrev.com/7c848788f642cd4c62cb11e890b4685f4a5f3b34 > Cr-Commit-Position: refs/heads/master@{#303827} TBR=dgozman@chromium.org,jbauman@chromium.org,vkuzkokov@chromium.org NOTREECHECKS=true NOTRY=true BUG=405566 Committed: https://crrev.com/20902dff04142ee703a45f988417ac96e7795e9e Cr-Commit-Position: refs/heads/master@{#303857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -128 lines) Patch
M content/browser/devtools/browser_protocol.json View 2 chunks +10 lines, -3 lines 0 comments Download
M content/browser/devtools/devtools_http_handler_impl.cc View 6 chunks +26 lines, -8 lines 0 comments Download
A content/browser/devtools/devtools_system_info_handler.h View 1 chunk +28 lines, -0 lines 0 comments Download
A content/browser/devtools/devtools_system_info_handler.cc View 1 chunk +130 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/system_info_handler.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/devtools/protocol/system_info_handler.cc View 2 chunks +2 lines, -92 lines 0 comments Download
M content/browser/gpu/compositor_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gpu/compositor_util.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M content/browser/gpu/gpu_internals_ui.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ernstm
Created Revert of [DevTools] Move SystemInfo domain to generated handler
6 years, 1 month ago (2014-11-12 18:26:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723623003/1
6 years, 1 month ago (2014-11-12 18:27:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-12 18:28:44 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 18:30:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20902dff04142ee703a45f988417ac96e7795e9e
Cr-Commit-Position: refs/heads/master@{#303857}

Powered by Google App Engine
This is Rietveld 408576698