sky/engine/core/html/imports/HTMLImportLoader.cpp - Issue 723583002: Make the parser an implementation detail of the Document

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/html/imports/HTMLImportLoader.cpp

Issue 723583002: Make the parser an implementation detail of the Document (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Rename textPosition to parserPosition Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/html/imports/HTMLImportLoader.cpp

diff --git a/sky/engine/core/html/imports/HTMLImportLoader.cpp b/sky/engine/core/html/imports/HTMLImportLoader.cpp

index 84ae5695b3a262c93f4e95f017d28f816fbe7c49..0b24a254b533cfca17bd67bd60ce583b2420149f 100644

--- a/sky/engine/core/html/imports/HTMLImportLoader.cpp

+++ b/sky/engine/core/html/imports/HTMLImportLoader.cpp

@@ -103,8 +103,7 @@ HTMLImportLoader::State HTMLImportLoader::startWritingAndParsing(mojo::URLRespon

.withRegistrationContext(m_controller->master()->registrationContext());

m_document = HTMLDocument::create(init);

m_module = Module::create(contextDocument.get(), nullptr, m_document.get(), url.string());

- m_document->startParsing();

- m_document->parser()->parse(response->body.Pass());

+ m_document->startParsing()->parse(response->body.Pass());

return StateLoading;

}

« no previous file with comments | « sky/engine/core/dom/StyleElement.cpp ('k') | sky/engine/core/loader/MojoLoader.cpp » ('j') | no next file with comments »