DevTools: Fix wrong pause reason when stepping into an event listener.

DevTools: Fix wrong pause reason when stepping into an event listener.

On StepInto we should not show "Paused on Event Listener".
The corresponding breakpoint may not even be active, so this status looks quite confusing.

BUG=432468
R=vsevik, yurys

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185362

[vsevik, 2014-11-13 12:46:18]

not lgtm

Looking at the way preparePauseOnNativeEventData is implemented in the if
(!m_pauseInNextEventListener) section it seems that we can actually stop on this
event listener only if it is active.
Hence this is actually a part of break on event listener functionality.

I think we would want to stop showing this message on steps once
https://code.google.com/p/chromium/issues/detail?id=432468 if fixed, but
currently everything seems correct already.

[vsevik, 2014-11-13 12:46:18]

not lgtm

Looking at the way preparePauseOnNativeEventData is implemented in the if
(!m_pauseInNextEventListener) section it seems that we can actually stop on this
event listener only if it is active.
Hence this is actually a part of break on event listener functionality.

I think we would want to stop showing this message on steps once
https://code.google.com/p/chromium/issues/detail?id=432468 if fixed, but
currently everything seems correct already.

[aandrey, 2014-11-13 13:34:22]

On 2014/11/13 12:46:18, vsevik wrote:
> not lgtm
> 
> Looking at the way preparePauseOnNativeEventData is implemented in the if
> (!m_pauseInNextEventListener) section it seems that we can actually stop on
this
> event listener only if it is active.
> Hence this is actually a part of break on event listener functionality.
> 
> I think we would want to stop showing this message on steps once
> https://code.google.com/p/chromium/issues/detail?id=432468 if fixed, but
> currently everything seems correct already.

This can not be a part of event listener functionality, since there is no event
listener breakpoint at all.

[vsevik, 2014-11-14 05:39:55]

lgtm

https://codereview.chromium.org/723543002/diff/1/LayoutTests/inspector/source...
File
LayoutTests/inspector/sources/debugger/debugger-step-into-event-listener.html
(right):

https://codereview.chromium.org/723543002/diff/1/LayoutTests/inspector/source...
LayoutTests/inspector/sources/debugger/debugger-step-into-event-listener.html:43:
InspectorTest.assertEquals(WebInspector.DebuggerModel.BreakReason.Other, reason,
"FAIL: wrong pause reason");
Please dump the break reason instead, it makes debugging such failures easier.

[aandrey, 2014-11-14 08:32:07]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-11-14 08:33:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/723543002/20001

[commit-bot: I haz the power, 2014-11-14 10:22:30]

Committed patchset #2 (id:20001) as 185362