Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 72353003: Avoid printing draw target info to stderr while running unit tests (Closed)

Created:
7 years, 1 month ago by Kimmo Kinnunen
Modified:
7 years, 1 month ago
Reviewers:
bsalomon, caryclark
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Avoid printing draw target info to stderr while running unit tests Change draw target dump function to return a SkString. Clients can do whatever they want with the string. BUG=skia:1837 Committed: http://code.google.com/p/skia/source/detail?r=12340

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -58 lines) Patch
M src/gpu/GrDrawTarget.cpp View 2 chunks +19 lines, -17 lines 0 comments Download
M src/gpu/GrDrawTargetCaps.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 2 chunks +33 lines, -32 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GrDrawTargetTest.cpp View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 6 (0 generated)
Kimmo Kinnunen
Would this work in use-cases GrDrawTargetCaps::print was used before? (I would probably #ifdef SKDEBUG or ...
7 years, 1 month ago (2013-11-14 06:17:05 UTC) #1
caryclark
This CL can be much more limited. It only needs to avoid using stdout/stderr during ...
7 years, 1 month ago (2013-11-14 12:52:16 UTC) #2
bsalomon
On 2013/11/14 12:52:16, caryclark wrote: > This CL can be much more limited. It only ...
7 years, 1 month ago (2013-11-14 16:51:57 UTC) #3
bsalomon
lgtm
7 years, 1 month ago (2013-11-21 14:49:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/72353003/1
7 years, 1 month ago (2013-11-21 14:49:56 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-21 15:23:17 UTC) #6
Message was sent while issue was closed.
Change committed as 12340

Powered by Google App Engine
This is Rietveld 408576698