Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 723473002: Remove unused Dictionary forward declaration and include (Closed)

Created:
6 years, 1 month ago by bashi
Modified:
6 years, 1 month ago
Reviewers:
haraken, sof
CC:
blink-reviews, blink-reviews-html_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, aandrey+blink_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove unused Dictionary forward declaration and include It seems that these are leftovers when I replaced Dictionary with IDL dictionaries. Added a forward declaration in Element.h instead (which is actually using Dictionary). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185197

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/core/dom/Element.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/MutationObserver.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/HitRegion.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
bashi
PTAL? This is a trivial fix.
6 years, 1 month ago (2014-11-12 09:16:10 UTC) #2
sof
lgtm
6 years, 1 month ago (2014-11-12 09:19:14 UTC) #4
bashi
On 2014/11/12 09:19:14, sof wrote: > lgtm Thanks!
6 years, 1 month ago (2014-11-12 09:19:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723473002/1
6 years, 1 month ago (2014-11-12 09:20:46 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 185197
6 years, 1 month ago (2014-11-12 10:22:06 UTC) #8
haraken
6 years, 1 month ago (2014-11-12 11:17:39 UTC) #9
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698