Issue 723453002: Remove unused NVPR related GL tokens

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 723453002: Remove unused NVPR related GL tokens (Closed)

Created:
6 years, 1 month ago by Kimmo Kinnunen

Modified:
6 years, 1 month ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@nvpr-conics

Project:
skia

Visibility:
Public.

More Reviews

Description

Remove unused NVPR related GL tokens Remove unused NVPR related GL tokens. Also replace GR_GL_PATH_INITIAL_END_CAP and GR_GL_PATH_TERMINAL_END_CAP with a single call setting GR_GL_PATH_END_CAPS. Skia does not and probably will not have different initial and terminal caps. This came up in the review of command buffer implementation of the extension. If more NVPR features will be used, the respective tokens can be added back per implemented feature. Committed: https://skia.googlesource.com/skia/+/542ecbb2bd1c8706f280edc3015d67b118d37817

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -83 lines)			Patch
	M	src/gpu/gl/GrGLDefines.h	View	1 2	1 chunk	+1 line, -77 lines	0 comments	Download
	M	src/gpu/gl/GrGLPath.cpp	View	1 2	1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723453002/40001

6 years, 1 month ago (2014-11-18 13:06:16 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-18 13:13:53 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/542ecbb2bd1c8706f280edc3015d67b118d37817

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 723453002: Remove unused NVPR related GL tokens (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase without conics dep #

Messages