tools/telemetry/telemetry/core/platform/posix_platform_backend.py - Issue 723403003: Shotdown browser cooperatively with taskill on win platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/posix_platform_backend.py

Issue 723403003: Shotdown browser cooperatively with taskill on win platform. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Tony's comment Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/platform_backend.py ('k') | tools/telemetry/telemetry/core/platform/win_platform_backend.py » ('j') | tools/telemetry/telemetry/core/platform/win_platform_backend.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/posix_platform_backend.py

diff --git a/tools/telemetry/telemetry/core/platform/posix_platform_backend.py b/tools/telemetry/telemetry/core/platform/posix_platform_backend.py

index 0f63632835b31838e314bba1fbfd5558639067ae..74e9927eec7746dcbcba3eaf4d2a11d56e16f2cd 100644

--- a/tools/telemetry/telemetry/core/platform/posix_platform_backend.py

+++ b/tools/telemetry/telemetry/core/platform/posix_platform_backend.py

@@ -132,3 +132,9 @@ class PosixPlatformBackend(desktop_platform_backend.DesktopPlatformBackend):

return subprocess.Popen(

args, stdout=subprocess.PIPE, stderr=stderror_destination)

+ def IsCooperativeShutdownSupported(self):

+ return True

+ def CooperativelyShutdown(self, proc):

+ proc.terminate()