Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 723393005: Add UseCounters for access to and change of Attr's child Text nodes (Closed)

Created:
6 years, 1 month ago by philipj_slow
Modified:
6 years, 1 month ago
Reviewers:
pdr.
CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Add UseCounters for access to and change of Attr's child Text nodes https://www.w3.org/Bugs/Public/show_bug.cgi?id=26609 This is in order to help determine if Attr could be made into a child-less Node like it is in Gecko. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185561

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M Source/core/dom/Attr.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Attr.idl View 1 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
philipj_slow
PTAL
6 years, 1 month ago (2014-11-18 22:13:25 UTC) #2
pdr.
LGTM https://codereview.chromium.org/723393005/diff/1/Source/core/dom/Attr.idl File Source/core/dom/Attr.idl (right): https://codereview.chromium.org/723393005/diff/1/Source/core/dom/Attr.idl#newcode44 Source/core/dom/Attr.idl:44: Ultranit: can you remove this extra newline?
6 years, 1 month ago (2014-11-18 22:19:48 UTC) #3
philipj_slow
https://codereview.chromium.org/723393005/diff/1/Source/core/dom/Attr.idl File Source/core/dom/Attr.idl (right): https://codereview.chromium.org/723393005/diff/1/Source/core/dom/Attr.idl#newcode44 Source/core/dom/Attr.idl:44: On 2014/11/18 22:19:48, pdr wrote: > Ultranit: can you ...
6 years, 1 month ago (2014-11-18 22:57:08 UTC) #4
philipj_slow
*silly style*
6 years, 1 month ago (2014-11-18 22:57:26 UTC) #5
philipj_slow
nit
6 years, 1 month ago (2014-11-18 22:58:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723393005/20001
6 years, 1 month ago (2014-11-18 23:00:09 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 00:52:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185561

Powered by Google App Engine
This is Rietveld 408576698