Chromium Code Reviews| Index: pkg/polymer/lib/transformer.dart |
| diff --git a/pkg/polymer/lib/transformer.dart b/pkg/polymer/lib/transformer.dart |
| index 6bcfbbeba569ce143ddcddedb4a14fc12b1368f8..051066d82aad20036ca9c3769568a6c0d238faad 100644 |
| --- a/pkg/polymer/lib/transformer.dart |
| +++ b/pkg/polymer/lib/transformer.dart |
| @@ -44,7 +44,15 @@ TransformOptions _parseSettings(BarbackSettings settings) { |
| bool csp = args['csp'] == true; // defaults to false |
| bool injectBuildLogs = |
| !releaseMode && args['inject_build_logs_in_output'] != false; |
| - bool injectPlatformJs = args['inject_platform_js'] != false; |
| + bool injectWebComponentsJs = true; |
| + if (args['inject_platform_js'] != null) { |
| + print('Invalid polymer transformer option `inject_platform_js`. This has ' |
|
Siggi Cherem (dart-lang)
2014/11/25 17:53:42
Invalid -> Deprecated?
jakemac
2014/12/01 18:42:51
Done.
|
| + 'been renamed `inject_web_components_js` to match the new file name.'); |
|
Siggi Cherem (dart-lang)
2014/11/25 17:53:42
since the file has no _, should it be inject_webco
jakemac
2014/12/01 18:42:51
yes true, it annoys me that they didn't put an _ i
|
| + injectWebComponentsJs = args['inject_platform_js'] != false; |
| + } |
| + if (args['inject_web_components_js'] != null) { |
| + injectWebComponentsJs = args['inject_web_components_js'] != false; |
| + } |
| return new TransformOptions( |
| entryPoints: readFileList(args['entry_points']), |
| inlineStylesheets: _readInlineStylesheets(args['inline_stylesheets']), |
| @@ -53,7 +61,7 @@ TransformOptions _parseSettings(BarbackSettings settings) { |
| releaseMode: releaseMode, |
| lint: _parseLintOption(args['lint']), |
| injectBuildLogsInOutput: injectBuildLogs, |
| - injectPlatformJs: injectPlatformJs); |
| + injectWebComponentsJs: injectWebComponentsJs); |
| } |
| // Lint option can be empty (all files), false, true, or a map indicating |