Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1398)

Unified Diff: pkg/observe/lib/src/path_observer.dart

Issue 723393003: update to polymer js 0.5.1 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: little bit of cleanup Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/observe/lib/src/path_observer.dart
diff --git a/pkg/observe/lib/src/path_observer.dart b/pkg/observe/lib/src/path_observer.dart
index 0ba31a673a1593b4cd309736ef217922a90baa08..d666c3b73ea51fc4a9e80565579682b818d74ada 100644
--- a/pkg/observe/lib/src/path_observer.dart
+++ b/pkg/observe/lib/src/path_observer.dart
@@ -234,8 +234,8 @@ class PropertyPath {
int i = 0, last = _segments.length - 1;
while (obj != null) {
// _segments[0] is passed to indicate that we are only observing that
Siggi Cherem (dart-lang) 2014/11/25 17:53:41 fix comment too? (0 -> i)?
jakemac 2014/12/01 18:42:51 Done.
- // property of obj. See observe declaration in _ObserveSet.
- observe(obj, _segments[0]);
+ // property of obj. See observe declaration in _ObservedSet.
+ observe(obj, _segments[i]);
if (i >= last) break;
obj = _getObjectProperty(obj, _segments[i++]);
@@ -865,6 +865,7 @@ class _ObservedSet {
}
_rootObject = null;
_rootObjectProperties = null;
+ if (identical(_lastSet, this)) _lastSet = null;
}
/// Observe now takes a second argument to indicate which property of an

Powered by Google App Engine
This is Rietveld 408576698