Source/core/frame/UseCounter.cpp - Issue 723373006: Add CSS parsing support for the scroll-blocks-on property (in place of touch-action-delay)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 723373006: Add CSS parsing support for the scroll-blocks-on property (in place of touch-action-delay) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« Source/core/css/parser/CSSPropertyParser.cpp ('K') | « Source/core/css/parser/CSSPropertyParser.cpp ('k') | Source/core/rendering/style/RenderStyle.h » ('j') | no next file with comments »

OLD	NEW
1	1

2 /*	2 /*

3 * Copyright (C) 2012 Google, Inc. All rights reserved.	3 * Copyright (C) 2012 Google, Inc. All rights reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions	6 * modification, are permitted provided that the following conditions

7 * are met:	7 * are met:

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 466 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
477 case CSSPropertyAnimationTimingFunction: return 432;	477 case CSSPropertyAnimationTimingFunction: return 432;

478 case CSSPropertyObjectFit: return 433;	478 case CSSPropertyObjectFit: return 433;

479 case CSSPropertyPaintOrder: return 434;	479 case CSSPropertyPaintOrder: return 434;

480 case CSSPropertyMaskSourceType: return 435;	480 case CSSPropertyMaskSourceType: return 435;

481 case CSSPropertyIsolation: return 436;	481 case CSSPropertyIsolation: return 436;

482 case CSSPropertyObjectPosition: return 437;	482 case CSSPropertyObjectPosition: return 437;

483 // case CSSPropertyInternalCallback: return 438;	483 // case CSSPropertyInternalCallback: return 438;

484 case CSSPropertyShapeImageThreshold: return 439;	484 case CSSPropertyShapeImageThreshold: return 439;

485 case CSSPropertyColumnFill: return 440;	485 case CSSPropertyColumnFill: return 440;

486 case CSSPropertyTextJustify: return 441;	486 case CSSPropertyTextJustify: return 441;

487 case CSSPropertyTouchActionDelay: return 442;	487 case CSSPropertyScrollBlocksOn: return 442;
	Timothy Loh 2014/11/14 22:06:41 Probably best to have a new return value here, eve Probably best to have a new return value here, even if touch-action-delay was only enabled in tests. Rick Byers 2014/11/18 03:03:08 Ok, done. scroll-blocks-on is really just a renam Show quoted text On 2014/11/14 22:06:41, Timothy Loh (OOO until 24th) wrote: > Probably best to have a new return value here, even if touch-action-delay was > only enabled in tests. Ok, done. scroll-blocks-on is really just a rename of touch-action-delay (in addition to becoming more general), but doesn't hurt. I expect the name may change again before shipping. In general we don't need to retain old values when we just rename, right?
488 case CSSPropertyJustifySelf: return 443;	488 case CSSPropertyJustifySelf: return 443;

489 case CSSPropertyScrollBehavior: return 444;	489 case CSSPropertyScrollBehavior: return 444;

490 case CSSPropertyWillChange: return 445;	490 case CSSPropertyWillChange: return 445;

491 case CSSPropertyTransform: return 446;	491 case CSSPropertyTransform: return 446;

492 case CSSPropertyTransformOrigin: return 447;	492 case CSSPropertyTransformOrigin: return 447;

493 case CSSPropertyTransformStyle: return 448;	493 case CSSPropertyTransformStyle: return 448;

494 case CSSPropertyPerspective: return 449;	494 case CSSPropertyPerspective: return 449;

495 case CSSPropertyPerspectiveOrigin: return 450;	495 case CSSPropertyPerspectiveOrigin: return 450;

496 case CSSPropertyBackfaceVisibility: return 451;	496 case CSSPropertyBackfaceVisibility: return 451;

497 case CSSPropertyGridTemplate: return 452;	497 case CSSPropertyGridTemplate: return 452;

(...skipping 362 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
860 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)	860 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)

861 {	861 {

862 // FIXME: We may want to handle stylesheets that have multiple owners	862 // FIXME: We may want to handle stylesheets that have multiple owners

863 // http://crbug.com/242125	863 // http://crbug.com/242125

864 if (sheetContents && sheetContents->hasSingleOwnerNode())	864 if (sheetContents && sheetContents->hasSingleOwnerNode())

865 return getFrom(sheetContents->singleOwnerDocument());	865 return getFrom(sheetContents->singleOwnerDocument());

866 return 0;	866 return 0;

867 }	867 }

868	868

869 } // namespace blink	869 } // namespace blink

OLD	NEW