Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: testing/chromoting/browser_tests_launcher.py

Issue 723343002: Update from https://crrev.com/304121 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: testing/chromoting/browser_tests_launcher.py
diff --git a/testing/chromoting/browser_tests_launcher.py b/testing/chromoting/browser_tests_launcher.py
index 66b54fedbb1526adf1df0680e4d49458121f1fbd..8f4bba19f938692d2ec188005e0e31f00abbe166 100644
--- a/testing/chromoting/browser_tests_launcher.py
+++ b/testing/chromoting/browser_tests_launcher.py
@@ -14,14 +14,14 @@ def LaunchCommand(command):
cmd_line = [command]
try:
- results = subprocess.check_output(
- cmd_line, stderr=subprocess.STDOUT, shell=True)
+ p = subprocess.Popen(cmd_line, stdout=subprocess.PIPE, shell=True)
+ results, err = p.communicate()
+ if 'SUCCESS: all tests passed.' not in results:
+ raise Exception('Test failed\n%s\n%s' % (results, err))
except subprocess.CalledProcessError, e:
raise Exception('Exception %s running command %s' % (e, command))
else:
print results
- finally:
- pass
def main():
« no previous file with comments | « testing/chromoting/browser_test_commands_linux.txt ('k') | testing/chromoting/chromoting_integration_tests.isolate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698