Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3047)

Unified Diff: build/android/pylib/base/base_test_runner.py

Issue 723343002: Update from https://crrev.com/304121 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/base/base_test_result.py ('k') | build/android/pylib/base/test_collection.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/base/base_test_runner.py
diff --git a/build/android/pylib/base/base_test_runner.py b/build/android/pylib/base/base_test_runner.py
index 1f76149be6c03c6ee0746db3f3a33322729c8942..6e51b43333a0399e49bf23b7f9c73f9670d4fda9 100644
--- a/build/android/pylib/base/base_test_runner.py
+++ b/build/android/pylib/base/base_test_runner.py
@@ -9,10 +9,8 @@
# model.
import logging
-import time
from pylib import ports
-from pylib.chrome_test_server_spawner import SpawningServer
from pylib.device import device_utils
from pylib.forwarder import Forwarder
from pylib.valgrind_tools import CreateTool
@@ -42,7 +40,6 @@ class BaseTestRunner(object):
self._forwarder_device_port = 8000
self.forwarder_base_url = ('http://localhost:%d' %
self._forwarder_device_port)
- self._spawning_server = None
# We will allocate port for test server spawner when calling method
# LaunchChromeTestServerSpawner and allocate port for test server when
# starting it in TestServerThread.
@@ -146,45 +143,4 @@ class BaseTestRunner(object):
if self._http_server:
self._UnmapPorts([(self._forwarder_device_port, self._http_server.port)])
self._http_server.ShutdownHttpServer()
- if self._spawning_server:
- self._spawning_server.Stop()
- def CleanupSpawningServerState(self):
- """Tells the spawning server to clean up any state.
-
- If the spawning server is reused for multiple tests, this should be called
- after each test to prevent tests affecting each other.
- """
- if self._spawning_server:
- self._spawning_server.CleanupState()
-
- def LaunchChromeTestServerSpawner(self):
- """Launches test server spawner."""
- server_ready = False
- error_msgs = []
- # TODO(pliard): deflake this function. The for loop should be removed as
- # well as IsHttpServerConnectable(). spawning_server.Start() should also
- # block until the server is ready.
- # Try 3 times to launch test spawner server.
- for _ in xrange(0, 3):
- self.test_server_spawner_port = ports.AllocateTestServerPort()
- self._ForwardPorts(
- [(self.test_server_spawner_port, self.test_server_spawner_port)])
- self._spawning_server = SpawningServer(self.test_server_spawner_port,
- self.device,
- self.tool)
- self._spawning_server.Start()
- server_ready, error_msg = ports.IsHttpServerConnectable(
- '127.0.0.1', self.test_server_spawner_port, path='/ping',
- expected_read='ready')
- if server_ready:
- break
- else:
- error_msgs.append(error_msg)
- self._spawning_server.Stop()
- # Wait for 2 seconds then restart.
- time.sleep(2)
- if not server_ready:
- logging.error(';'.join(error_msgs))
- raise Exception('Can not start the test spawner server.')
- self._PushTestServerPortInfoToDevice()
« no previous file with comments | « build/android/pylib/base/base_test_result.py ('k') | build/android/pylib/base/test_collection.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698