| Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
|
| diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
|
| index e97b4c4eb95ef30606a788d2ee8512687c735cb2..0ef9585b6482190e8b58c058078b8da1cc11c62e 100644
|
| --- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
|
| +++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
|
| @@ -266,154 +266,6 @@ TEST_P(GLES2DecoderTest, IsTexture) {
|
| EXPECT_FALSE(DoIsTexture(client_texture_id_));
|
| }
|
|
|
| -TEST_P(GLES2DecoderTest, GetMultipleIntegervCHROMIUMValidArgs) {
|
| - const GLsizei kCount = 3;
|
| - GLenum* pnames = GetSharedMemoryAs<GLenum*>();
|
| - pnames[0] = GL_DEPTH_WRITEMASK;
|
| - pnames[1] = GL_COLOR_WRITEMASK;
|
| - pnames[2] = GL_STENCIL_WRITEMASK;
|
| - GLint* results =
|
| - GetSharedMemoryAsWithOffset<GLint*>(sizeof(*pnames) * kCount);
|
| -
|
| - GLsizei num_results = 0;
|
| - for (GLsizei ii = 0; ii < kCount; ++ii) {
|
| - num_results += decoder_->GetGLES2Util()->GLGetNumValuesReturned(pnames[ii]);
|
| - }
|
| - const GLsizei result_size = num_results * sizeof(*results);
|
| - memset(results, 0, result_size);
|
| -
|
| - const GLint kSentinel = 0x12345678;
|
| - results[num_results] = kSentinel;
|
| -
|
| - GetMultipleIntegervCHROMIUM cmd;
|
| - cmd.Init(kSharedMemoryId,
|
| - kSharedMemoryOffset,
|
| - kCount,
|
| - kSharedMemoryId,
|
| - kSharedMemoryOffset + sizeof(*pnames) * kCount,
|
| - result_size);
|
| -
|
| - EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));
|
| - EXPECT_EQ(GL_NO_ERROR, GetGLError());
|
| - EXPECT_EQ(1, results[0]); // Depth writemask
|
| - EXPECT_EQ(1, results[1]); // color writemask red
|
| - EXPECT_EQ(1, results[2]); // color writemask green
|
| - EXPECT_EQ(1, results[3]); // color writemask blue
|
| - EXPECT_EQ(1, results[4]); // color writemask alpha
|
| - EXPECT_EQ(-1, results[5]); // stencil writemask alpha
|
| - EXPECT_EQ(kSentinel, results[num_results]); // End of results
|
| -}
|
| -
|
| -TEST_P(GLES2DecoderTest, GetMultipleIntegervCHROMIUMInvalidArgs) {
|
| - const GLsizei kCount = 3;
|
| - // Offset the pnames because GLGetError will use the first uint32.
|
| - const uint32 kPnameOffset = sizeof(uint32);
|
| - const uint32 kResultsOffset = kPnameOffset + sizeof(GLint) * kCount;
|
| - GLenum* pnames = GetSharedMemoryAsWithOffset<GLenum*>(kPnameOffset);
|
| - pnames[0] = GL_DEPTH_WRITEMASK;
|
| - pnames[1] = GL_COLOR_WRITEMASK;
|
| - pnames[2] = GL_STENCIL_WRITEMASK;
|
| - GLint* results = GetSharedMemoryAsWithOffset<GLint*>(kResultsOffset);
|
| -
|
| - GLsizei num_results = 0;
|
| - for (GLsizei ii = 0; ii < kCount; ++ii) {
|
| - num_results += decoder_->GetGLES2Util()->GLGetNumValuesReturned(pnames[ii]);
|
| - }
|
| - const GLsizei result_size = num_results * sizeof(*results);
|
| - memset(results, 0, result_size);
|
| -
|
| - const GLint kSentinel = 0x12345678;
|
| - results[num_results] = kSentinel;
|
| -
|
| - GetMultipleIntegervCHROMIUM cmd;
|
| - // Check bad pnames pointer.
|
| - cmd.Init(kInvalidSharedMemoryId,
|
| - kSharedMemoryOffset + kPnameOffset,
|
| - kCount,
|
| - kSharedMemoryId,
|
| - kSharedMemoryOffset + kResultsOffset,
|
| - result_size);
|
| - EXPECT_EQ(error::kOutOfBounds, ExecuteCmd(cmd));
|
| - EXPECT_EQ(GL_NO_ERROR, GetGLError());
|
| - // Check bad pnames pointer.
|
| - cmd.Init(kSharedMemoryId,
|
| - kInvalidSharedMemoryOffset,
|
| - kCount,
|
| - kSharedMemoryId,
|
| - kSharedMemoryOffset + kResultsOffset,
|
| - result_size);
|
| - EXPECT_EQ(error::kOutOfBounds, ExecuteCmd(cmd));
|
| - EXPECT_EQ(GL_NO_ERROR, GetGLError());
|
| - // Check bad count.
|
| - cmd.Init(kSharedMemoryId,
|
| - kSharedMemoryOffset + kPnameOffset,
|
| - static_cast<GLuint>(-1),
|
| - kSharedMemoryId,
|
| - kSharedMemoryOffset + kResultsOffset,
|
| - result_size);
|
| - EXPECT_EQ(error::kOutOfBounds, ExecuteCmd(cmd));
|
| - EXPECT_EQ(GL_NO_ERROR, GetGLError());
|
| - // Check bad results pointer.
|
| - cmd.Init(kSharedMemoryId,
|
| - kSharedMemoryOffset + kPnameOffset,
|
| - kCount,
|
| - kInvalidSharedMemoryId,
|
| - kSharedMemoryOffset + kResultsOffset,
|
| - result_size);
|
| - EXPECT_EQ(error::kOutOfBounds, ExecuteCmd(cmd));
|
| - EXPECT_EQ(GL_NO_ERROR, GetGLError());
|
| - // Check bad results pointer.
|
| - cmd.Init(kSharedMemoryId,
|
| - kSharedMemoryOffset + kPnameOffset,
|
| - kCount,
|
| - kSharedMemoryId,
|
| - kInvalidSharedMemoryOffset,
|
| - result_size);
|
| - EXPECT_EQ(error::kOutOfBounds, ExecuteCmd(cmd));
|
| - EXPECT_EQ(GL_NO_ERROR, GetGLError());
|
| - // Check bad size.
|
| - cmd.Init(kSharedMemoryId,
|
| - kSharedMemoryOffset + kPnameOffset,
|
| - kCount,
|
| - kSharedMemoryId,
|
| - kSharedMemoryOffset + kResultsOffset,
|
| - result_size + 1);
|
| - EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));
|
| - EXPECT_EQ(GL_INVALID_VALUE, GetGLError());
|
| - // Check bad size.
|
| - cmd.Init(kSharedMemoryId,
|
| - kSharedMemoryOffset + kPnameOffset,
|
| - kCount,
|
| - kSharedMemoryId,
|
| - kSharedMemoryOffset + kResultsOffset,
|
| - result_size - 1);
|
| - EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));
|
| - EXPECT_EQ(GL_INVALID_VALUE, GetGLError());
|
| - // Check bad enum.
|
| - cmd.Init(kSharedMemoryId,
|
| - kSharedMemoryOffset + kPnameOffset,
|
| - kCount,
|
| - kSharedMemoryId,
|
| - kSharedMemoryOffset + kResultsOffset,
|
| - result_size);
|
| - GLenum temp = pnames[2];
|
| - pnames[2] = GL_TRUE;
|
| - EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));
|
| - EXPECT_EQ(GL_INVALID_ENUM, GetGLError());
|
| - pnames[2] = temp;
|
| - // Check results area has not been cleared by client.
|
| - results[1] = 1;
|
| - EXPECT_EQ(error::kInvalidArguments, ExecuteCmd(cmd));
|
| - // Check buffer is what we expect
|
| - EXPECT_EQ(0, results[0]);
|
| - EXPECT_EQ(1, results[1]);
|
| - EXPECT_EQ(0, results[2]);
|
| - EXPECT_EQ(0, results[3]);
|
| - EXPECT_EQ(0, results[4]);
|
| - EXPECT_EQ(0, results[5]);
|
| - EXPECT_EQ(kSentinel, results[num_results]); // End of results
|
| -}
|
| -
|
| TEST_P(GLES2DecoderManualInitTest, BindGeneratesResourceFalse) {
|
| InitState init;
|
| init.gl_version = "3.0";
|
| @@ -636,7 +488,7 @@ static void CheckBeginEndQueryBadMemoryFails(GLES2DecoderTestBase* test,
|
|
|
| QueryManager* query_manager = test->GetDecoder()->GetQueryManager();
|
| ASSERT_TRUE(query_manager != NULL);
|
| - bool process_success = query_manager->ProcessPendingQueries();
|
| + bool process_success = query_manager->ProcessPendingQueries(false);
|
|
|
| EXPECT_TRUE(error1 != error::kNoError || error2 != error::kNoError ||
|
| !process_success);
|
| @@ -797,7 +649,7 @@ TEST_P(GLES2DecoderManualInitTest, BeginEndQueryEXTCommandsCompletedCHROMIUM) {
|
| EXPECT_CALL(*gl_, ClientWaitSync(kGlSync, _, _))
|
| .WillOnce(Return(GL_TIMEOUT_EXPIRED))
|
| .RetiresOnSaturation();
|
| - bool process_success = query_manager->ProcessPendingQueries();
|
| + bool process_success = query_manager->ProcessPendingQueries(false);
|
|
|
| EXPECT_TRUE(process_success);
|
| EXPECT_TRUE(query->pending());
|
| @@ -810,7 +662,7 @@ TEST_P(GLES2DecoderManualInitTest, BeginEndQueryEXTCommandsCompletedCHROMIUM) {
|
| EXPECT_CALL(*gl_, ClientWaitSync(kGlSync, _, _))
|
| .WillOnce(Return(GL_ALREADY_SIGNALED))
|
| .RetiresOnSaturation();
|
| - process_success = query_manager->ProcessPendingQueries();
|
| + process_success = query_manager->ProcessPendingQueries(false);
|
|
|
| EXPECT_TRUE(process_success);
|
| EXPECT_FALSE(query->pending());
|
|
|