Index: net/socket/ssl_client_socket_nss.cc |
diff --git a/net/socket/ssl_client_socket_nss.cc b/net/socket/ssl_client_socket_nss.cc |
index 31a9b8d8379e31bbb6f8a3f16c9950794f23d7d3..3e5bde05fa7ce8a8619b29dae69c7181192147df 100644 |
--- a/net/socket/ssl_client_socket_nss.cc |
+++ b/net/socket/ssl_client_socket_nss.cc |
@@ -218,8 +218,6 @@ bool IsOCSPStaplingSupported() { |
return GetCacheOCSPResponseFromSideChannelFunction() != NULL; |
} |
#else |
-// TODO(agl): Figure out if we can plumb the OCSP response into Mac's system |
-// certificate validation functions. |
bool IsOCSPStaplingSupported() { |
return false; |
} |
@@ -1292,7 +1290,7 @@ SECStatus SSLClientSocketNSS::Core::PlatformClientAuthHandler( |
core->client_auth_cert_needed_ = !core->ssl_config_.send_client_cert; |
#if defined(OS_WIN) |
if (core->ssl_config_.send_client_cert) { |
- if (core->ssl_config_.client_cert) { |
+ if (core->ssl_config_.client_cert.get()) { |
PCCERT_CONTEXT cert_context = |
core->ssl_config_.client_cert->os_cert_handle(); |
@@ -1630,8 +1628,8 @@ void SSLClientSocketNSS::Core::HandshakeCallback( |
} |
void SSLClientSocketNSS::Core::HandshakeSucceeded() { |
- // TODO(vadimt): Remove ScopedProfile below once crbug.com/424386 is fixed. |
- tracked_objects::ScopedProfile tracking_profile( |
+ // TODO(vadimt): Remove ScopedTracker below once crbug.com/424386 is fixed. |
+ tracked_objects::ScopedTracker tracking_profile( |
FROM_HERE_WITH_EXPLICIT_FUNCTION( |
"424386 SSLClientSocketNSS::Core::HandshakeSucceeded")); |
@@ -1661,8 +1659,8 @@ void SSLClientSocketNSS::Core::HandshakeSucceeded() { |
} |
int SSLClientSocketNSS::Core::HandleNSSError(PRErrorCode nss_error) { |
- // TODO(vadimt): Remove ScopedProfile below once crbug.com/424386 is fixed. |
- tracked_objects::ScopedProfile tracking_profile( |
+ // TODO(vadimt): Remove ScopedTracker below once crbug.com/424386 is fixed. |
+ tracked_objects::ScopedTracker tracking_profile( |
FROM_HERE_WITH_EXPLICIT_FUNCTION( |
"424386 SSLClientSocketNSS::Core::HandleNSSError")); |
@@ -1687,7 +1685,7 @@ int SSLClientSocketNSS::Core::HandleNSSError(PRErrorCode nss_error) { |
// re-insert the smart card if not. |
if ((net_error == ERR_SSL_CLIENT_AUTH_CERT_NO_PRIVATE_KEY || |
net_error == ERR_SSL_CLIENT_AUTH_SIGNATURE_FAILED) && |
- ssl_config_.send_client_cert && ssl_config_.client_cert) { |
+ ssl_config_.send_client_cert && ssl_config_.client_cert.get()) { |
CertSetCertificateContextProperty( |
ssl_config_.client_cert->os_cert_handle(), |
CERT_KEY_PROV_HANDLE_PROP_ID, 0, NULL); |
@@ -1813,8 +1811,8 @@ int SSLClientSocketNSS::Core::DoHandshake() { |
int net_error = OK; |
SECStatus rv = SSL_ForceHandshake(nss_fd_); |
- // TODO(vadimt): Remove ScopedProfile below once crbug.com/424386 is fixed. |
- tracked_objects::ScopedProfile tracking_profile1( |
+ // TODO(vadimt): Remove ScopedTracker below once crbug.com/424386 is fixed. |
+ tracked_objects::ScopedTracker tracking_profile1( |
FROM_HERE_WITH_EXPLICIT_FUNCTION( |
"424386 SSLClientSocketNSS::Core::DoHandshake 1")); |
@@ -2436,11 +2434,9 @@ void SSLClientSocketNSS::Core::UpdateStapledOCSPResponse() { |
reinterpret_cast<char*>(ocsp_responses->items[0].data), |
ocsp_responses->items[0].len); |
- // TODO(agl): figure out how to plumb an OCSP response into the Mac |
- // system library and update IsOCSPStaplingSupported for Mac. |
if (IsOCSPStaplingSupported()) { |
#if defined(OS_WIN) |
- if (nss_handshake_state_.server_cert) { |
+ if (nss_handshake_state_.server_cert.get()) { |
CRYPT_DATA_BLOB ocsp_response_blob; |
ocsp_response_blob.cbData = ocsp_responses->items[0].len; |
ocsp_response_blob.pbData = ocsp_responses->items[0].data; |