Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1757)

Unified Diff: net/cert/ct_serialization_unittest.cc

Issue 72333007: Add an SignedCertificateTimetampStore, making SignedCertificateTimestamp be refcounted to aid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@piecewise
Patch Set: Fixes for wtc. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/ct_serialization_unittest.cc
diff --git a/net/cert/ct_serialization_unittest.cc b/net/cert/ct_serialization_unittest.cc
index 03fc03471213b3080c2b66fe606718932c83f023..d832c1d8ef1bda30ff3e24b24c8f1c7a6f9a3f1a 100644
--- a/net/cert/ct_serialization_unittest.cc
+++ b/net/cert/ct_serialization_unittest.cc
@@ -135,23 +135,23 @@ TEST_F(CtSerializationTest, DecodesSignedCertificateTimestamp) {
std::string encoded_test_sct(ct::GetTestSignedCertificateTimestamp());
base::StringPiece encoded_sct(encoded_test_sct);
- ct::SignedCertificateTimestamp sct;
+ scoped_refptr<ct::SignedCertificateTimestamp> sct;
ASSERT_TRUE(ct::DecodeSignedCertificateTimestamp(&encoded_sct, &sct));
- EXPECT_EQ(0, sct.version);
- EXPECT_EQ(ct::GetTestPublicKeyId(), sct.log_id);
+ EXPECT_EQ(0, sct->version);
+ EXPECT_EQ(ct::GetTestPublicKeyId(), sct->log_id);
base::Time expected_time = base::Time::UnixEpoch() +
base::TimeDelta::FromMilliseconds(1365181456089);
- EXPECT_EQ(expected_time, sct.timestamp);
+ EXPECT_EQ(expected_time, sct->timestamp);
// Subtracting 4 bytes for signature data (hash & sig algs),
// actual signature data should be 71 bytes.
- EXPECT_EQ((size_t) 71, sct.signature.signature_data.size());
- EXPECT_EQ(std::string(""), sct.extensions);
+ EXPECT_EQ((size_t) 71, sct->signature.signature_data.size());
+ EXPECT_EQ(std::string(""), sct->extensions);
}
TEST_F(CtSerializationTest, FailsDecodingInvalidSignedCertificateTimestamp) {
// Invalid version
base::StringPiece invalid_version_sct("\x2\x0", 2);
- ct::SignedCertificateTimestamp sct;
+ scoped_refptr<ct::SignedCertificateTimestamp> sct;
ASSERT_FALSE(
ct::DecodeSignedCertificateTimestamp(&invalid_version_sct, &sct));

Powered by Google App Engine
This is Rietveld 408576698