Add an SignedCertificateTimetampStore, making SignedCertificateTimestamp be refcounted to aid.

content/browser/sct_store_impl.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_SCT_STORE_IMPL_H_
+#define CONTENT_BROWSER_SCT_STORE_IMPL_H_
+
+#include "base/memory/singleton.h"
+#include "content/browser/renderer_data_memoizing_store.h"
+#include "content/public/browser/sct_store.h"
+#include "net/cert/signed_certificate_timestamp.h"
+
+namespace content {
+
+class SignedCertificateTimestampStoreImpl

[wtc, 2013/11/19 01:57:40]

The Style Guide recommends that these two files be named
signed_certificate_timestamp_store_impl.{h,c} to match the class name.

[alcutter, 2013/11/19 15:51:34]

Done.

+    : public SignedCertificateTimestampStore {
+ public:
+  // Returns the singleton instance of the SignedCertificateTimestampStore.
+  static SignedCertificateTimestampStoreImpl* GetInstance();

[wtc, 2013/11/19 01:57:40]

It seems that we don't need a GetInstance() method in the Impl class.

[alcutter, 2013/11/19 15:51:34]

Looks to be a requirement of the singleton template that the type T passed in to
Singleton<T> must have a GetInstance() method.

The GetInstance in the public SignedCertificateTimestamp interface just
delegates to this one.

This is the same pattern as the [pre-existing] cert_store code uses.

+
+  // SignedCertificateTimestampStore implementation:
+  virtual int StoreSignedCertificateTimestamp(
+      net::ct::SignedCertificateTimestamp* sct,
+      int render_process_host_id) OVERRIDE;
+  virtual bool RetrieveSignedCertificateTimestamp(
+      int sct_id,
+      scoped_refptr<net::ct::SignedCertificateTimestamp>* sct) OVERRIDE;
+
+ protected:
+  SignedCertificateTimestampStoreImpl();
+  virtual ~SignedCertificateTimestampStoreImpl();

[wtc, 2013/11/19 01:57:40]

Both of these can probably be private because I don't think this class will have
subclasses.

[alcutter, 2013/11/20 12:53:29]

(did this in a previous patch)

+
+ private:
+  friend struct DefaultSingletonTraits<SignedCertificateTimestampStoreImpl>;
+
+  RendererDataMemoizingStore<net::ct::SignedCertificateTimestamp> store_;
+
+  DISALLOW_COPY_AND_ASSIGN(SignedCertificateTimestampStoreImpl);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_SCT_STORE_IMPL_H_