Add an SignedCertificateTimetampStore, making SignedCertificateTimestamp be refcounted to aid.

net/test/ct_test_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/test/ct_test_util.h"
 
 #include <string>
 #include <vector>
 
 #include "base/strings/string_number_conversions.h"
@@ skipping 113 matching lines @@
 }
 
 std::string GetTestPublicKey() {
   return HexToBytes(kEcP256PublicKey);
 }
 
 std::string GetTestPublicKeyId() {
   return HexToBytes(kTestKeyId);
 }
 
-void GetX509CertSCT(SignedCertificateTimestamp* sct) {
-  sct->log_id = HexToBytes(kTestKeyId);
-  sct->timestamp = base::Time::UnixEpoch() +
+void GetX509CertSCT(scoped_refptr<SignedCertificateTimestamp>* sct) {
+  CHECK(sct != NULL);

[agl, 2013/11/19 16:12:40]

nit: it would also be fine to have the argument be called sct_ref and then

SignedCertificateTimestamp *const sct(sct_ref.get());

In order to avoid all the (*sct) stuff.

(Up to you. No need to change.)

[alcutter, 2013/11/19 18:03:48]

"My god, it's full of stars."

Good idea, done.

+  *sct = new SignedCertificateTimestamp();
+  (*sct)->log_id = HexToBytes(kTestKeyId);
+  (*sct)->timestamp = base::Time::UnixEpoch() +
       base::TimeDelta::FromMilliseconds(GG_UINT64_C(1365181456089));
-  sct->extensions.clear();
+  (*sct)->extensions.clear();
 
-  sct->signature.hash_algorithm = ct::DigitallySigned::HASH_ALGO_SHA256;
-  sct->signature.signature_algorithm = ct::DigitallySigned::SIG_ALGO_ECDSA;
-  sct->signature.signature_data = HexToBytes(kTestSCTSignatureData);
+  (*sct)->signature.hash_algorithm = ct::DigitallySigned::HASH_ALGO_SHA256;
+  (*sct)->signature.signature_algorithm = ct::DigitallySigned::SIG_ALGO_ECDSA;
+  (*sct)->signature.signature_data = HexToBytes(kTestSCTSignatureData);
 }
 
-void GetPrecertSCT(SignedCertificateTimestamp* sct) {
-  sct->log_id = HexToBytes(kTestKeyId);
-  sct->timestamp = base::Time::UnixEpoch() +
+void GetPrecertSCT(scoped_refptr<SignedCertificateTimestamp>* sct) {
+  CHECK(sct != NULL);
+  *sct = new SignedCertificateTimestamp();
+  (*sct)->log_id = HexToBytes(kTestKeyId);
+  (*sct)->timestamp = base::Time::UnixEpoch() +
     base::TimeDelta::FromMilliseconds(GG_UINT64_C(1365181456275));
-  sct->extensions.clear();
+  (*sct)->extensions.clear();
 
-  sct->signature.hash_algorithm = ct::DigitallySigned::HASH_ALGO_SHA256;
-  sct->signature.signature_algorithm = ct::DigitallySigned::SIG_ALGO_ECDSA;
-  sct->signature.signature_data = HexToBytes(kTestSCTPrecertSignatureData);
+  (*sct)->signature.hash_algorithm = ct::DigitallySigned::HASH_ALGO_SHA256;
+  (*sct)->signature.signature_algorithm = ct::DigitallySigned::SIG_ALGO_ECDSA;
+  (*sct)->signature.signature_data = HexToBytes(kTestSCTPrecertSignatureData);
 }
 
 }  // namespace ct
 
 }  // namespace net