Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 72333004: Match max property descriptor length to corresponding bit fields (Closed)

Created:
7 years, 1 month ago by danno
Modified:
7 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Match max property descriptor length to corresponding bit fields BUG=v8:3010 R=verwaest@chromium.org LOG=N Committed: http://code.google.com/p/v8/source/detail?r=17823

Patch Set 1 #

Patch Set 2 : Better test case #

Patch Set 3 : Toons feedback #

Patch Set 4 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -38 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/handles.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/heap.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 2 3 4 chunks +15 lines, -19 lines 0 comments Download
M src/objects.cc View 1 2 3 8 chunks +9 lines, -10 lines 0 comments Download
M src/property-details.h View 1 2 3 2 chunks +17 lines, -3 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-3010.js View 1 2 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danno
PTAL
7 years, 1 month ago (2013-11-18 10:29:12 UTC) #1
danno
7 years, 1 month ago (2013-11-18 10:29:23 UTC) #2
Toon Verwaest
lgtm
7 years, 1 month ago (2013-11-18 11:05:35 UTC) #3
danno
7 years, 1 month ago (2013-11-18 11:44:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r17823 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698