Issue 723283003: Fix submodule-merge-test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 723283003: Fix submodule-merge-test. (Closed)

Created:
6 years ago by iannucci

Modified:
6 years ago

Reviewers:
agable, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Project:
tools

Visibility:
Public.

More Reviews

Description

Fix submodule-merge-test. R=agable@chromium.org, maruel@chromium.org BUG=

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tests/submodule-merge-test.sh	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/test-lib.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

iannucci

On 2014/12/05 02:08:49, M-A Ruel wrote: > eh, lgtm yeah, exactly...

6 years ago (2014-12-05 02:13:13 UTC) #3

iannucci

On 2014/12/05 02:13:13, iannucci wrote: > On 2014/12/05 02:08:49, M-A Ruel wrote: > > eh, ...

6 years ago (2014-12-05 02:14:59 UTC) #4

M-A Ruel

6 years ago (2014-12-05 02:21:06 UTC) #5

Message was sent while issue was closed.

On 2014/12/05 02:14:59, iannucci wrote:
> On 2014/12/05 02:13:13, iannucci wrote:
> > On 2014/12/05 02:08:49, M-A Ruel wrote:
> > > eh, lgtm
> > 
> > yeah, exactly...
> 
> oh... wait... maybe this is a trusty thing. bah... I think that's actually the
> issue here... all of these tests suck.... maybe I should just focus on
removing
> svn and thereby removing git-svn and we can just pretend that none of this
> happened.

Fine with me.

Expand Messages | Collapse Messages