sky/engine/platform/Supplementable.h - Issue 723253004: Remove tons of OILPAN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/platform/Supplementable.h

Issue 723253004: Remove tons of OILPAN. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/platform/Supplementable.h

diff --git a/sky/engine/platform/Supplementable.h b/sky/engine/platform/Supplementable.h

index 9efa8c1481f33064455086cd2ec683f27742b122..a06d8701b6bf7d479f9983ec9c83db1e36cbc68b 100644

--- a/sky/engine/platform/Supplementable.h

+++ b/sky/engine/platform/Supplementable.h

@@ -170,7 +170,6 @@ public:

// the vtable at the first word of the object. However we don't trace the

// m_supplements here, but in the partially specialized template subclasses

// since we only want to trace it for garbage collected classes.

- virtual void trace(Visitor*) { }

// FIXME: Oilpan: Make private and remove this ignore once PersistentHeapSupplementable is removed again.

protected: