Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: sky/engine/core/css/CSSValue.cpp

Issue 723253004: Remove tons of OILPAN. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/css/CSSValue.h ('k') | sky/engine/core/css/CSSValueList.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/css/CSSValue.cpp
diff --git a/sky/engine/core/css/CSSValue.cpp b/sky/engine/core/css/CSSValue.cpp
index 6cc0a7012d3daf413460b62135e8d00cdfc8a04a..b2fc80e76502a252d178b5bb80f54887061c45e0 100644
--- a/sky/engine/core/css/CSSValue.cpp
+++ b/sky/engine/core/css/CSSValue.cpp
@@ -69,8 +69,6 @@ public:
String cssText() const { return m_cssText; }
- void traceAfterDispatch(Visitor* visitor) { CSSValue::traceAfterDispatch(visitor); }
-
private:
TextCloneCSSValue(ClassType classType, const String& text)
: CSSValue(classType, /*isCSSOMSafe*/ true)
@@ -350,184 +348,6 @@ void CSSValue::destroy()
ASSERT_NOT_REACHED();
}
-void CSSValue::finalizeGarbageCollectedObject()
-{
- if (m_isTextClone) {
- ASSERT(isCSSOMSafe());
- toTextCloneCSSValue(this)->~TextCloneCSSValue();
- return;
- }
- ASSERT(!isCSSOMSafe() || isSubtypeExposedToCSSOM());
-
- switch (classType()) {
- case AspectRatioClass:
- toCSSAspectRatioValue(this)->~CSSAspectRatioValue();
- return;
- case BorderImageSliceClass:
- toCSSBorderImageSliceValue(this)->~CSSBorderImageSliceValue();
- return;
- case CanvasClass:
- toCSSCanvasValue(this)->~CSSCanvasValue();
- return;
- case CursorImageClass:
- toCSSCursorImageValue(this)->~CSSCursorImageValue();
- return;
- case FontClass:
- toCSSFontValue(this)->~CSSFontValue();
- return;
- case FontFaceSrcClass:
- toCSSFontFaceSrcValue(this)->~CSSFontFaceSrcValue();
- return;
- case FontFeatureClass:
- toCSSFontFeatureValue(this)->~CSSFontFeatureValue();
- return;
- case FunctionClass:
- toCSSFunctionValue(this)->~CSSFunctionValue();
- return;
- case LinearGradientClass:
- toCSSLinearGradientValue(this)->~CSSLinearGradientValue();
- return;
- case RadialGradientClass:
- toCSSRadialGradientValue(this)->~CSSRadialGradientValue();
- return;
- case CrossfadeClass:
- toCSSCrossfadeValue(this)->~CSSCrossfadeValue();
- return;
- case ImageClass:
- toCSSImageValue(this)->~CSSImageValue();
- return;
- case InheritedClass:
- toCSSInheritedValue(this)->~CSSInheritedValue();
- return;
- case InitialClass:
- toCSSInitialValue(this)->~CSSInitialValue();
- return;
- case PrimitiveClass:
- toCSSPrimitiveValue(this)->~CSSPrimitiveValue();
- return;
- case ShadowClass:
- toCSSShadowValue(this)->~CSSShadowValue();
- return;
- case CubicBezierTimingFunctionClass:
- toCSSCubicBezierTimingFunctionValue(this)->~CSSCubicBezierTimingFunctionValue();
- return;
- case StepsTimingFunctionClass:
- toCSSStepsTimingFunctionValue(this)->~CSSStepsTimingFunctionValue();
- return;
- case UnicodeRangeClass:
- toCSSUnicodeRangeValue(this)->~CSSUnicodeRangeValue();
- return;
- case ValueListClass:
- toCSSValueList(this)->~CSSValueList();
- return;
- case CSSTransformClass:
- toCSSTransformValue(this)->~CSSTransformValue();
- return;
- case LineBoxContainClass:
- toCSSLineBoxContainValue(this)->~CSSLineBoxContainValue();
- return;
- case CalculationClass:
- toCSSCalcValue(this)->~CSSCalcValue();
- return;
- case ImageSetClass:
- toCSSImageSetValue(this)->~CSSImageSetValue();
- return;
- case CSSFilterClass:
- toCSSFilterValue(this)->~CSSFilterValue();
- return;
- }
- ASSERT_NOT_REACHED();
-}
-
-void CSSValue::trace(Visitor* visitor)
-{
- if (m_isTextClone) {
- ASSERT(isCSSOMSafe());
- toTextCloneCSSValue(this)->traceAfterDispatch(visitor);
- return;
- }
- ASSERT(!isCSSOMSafe() || isSubtypeExposedToCSSOM());
-
- switch (classType()) {
- case AspectRatioClass:
- toCSSAspectRatioValue(this)->traceAfterDispatch(visitor);
- return;
- case BorderImageSliceClass:
- toCSSBorderImageSliceValue(this)->traceAfterDispatch(visitor);
- return;
- case CanvasClass:
- toCSSCanvasValue(this)->traceAfterDispatch(visitor);
- return;
- case CursorImageClass:
- toCSSCursorImageValue(this)->traceAfterDispatch(visitor);
- return;
- case FontClass:
- toCSSFontValue(this)->traceAfterDispatch(visitor);
- return;
- case FontFaceSrcClass:
- toCSSFontFaceSrcValue(this)->traceAfterDispatch(visitor);
- return;
- case FontFeatureClass:
- toCSSFontFeatureValue(this)->traceAfterDispatch(visitor);
- return;
- case FunctionClass:
- toCSSFunctionValue(this)->traceAfterDispatch(visitor);
- return;
- case LinearGradientClass:
- toCSSLinearGradientValue(this)->traceAfterDispatch(visitor);
- return;
- case RadialGradientClass:
- toCSSRadialGradientValue(this)->traceAfterDispatch(visitor);
- return;
- case CrossfadeClass:
- toCSSCrossfadeValue(this)->traceAfterDispatch(visitor);
- return;
- case ImageClass:
- toCSSImageValue(this)->traceAfterDispatch(visitor);
- return;
- case InheritedClass:
- toCSSInheritedValue(this)->traceAfterDispatch(visitor);
- return;
- case InitialClass:
- toCSSInitialValue(this)->traceAfterDispatch(visitor);
- return;
- case PrimitiveClass:
- toCSSPrimitiveValue(this)->traceAfterDispatch(visitor);
- return;
- case ShadowClass:
- toCSSShadowValue(this)->traceAfterDispatch(visitor);
- return;
- case CubicBezierTimingFunctionClass:
- toCSSCubicBezierTimingFunctionValue(this)->traceAfterDispatch(visitor);
- return;
- case StepsTimingFunctionClass:
- toCSSStepsTimingFunctionValue(this)->traceAfterDispatch(visitor);
- return;
- case UnicodeRangeClass:
- toCSSUnicodeRangeValue(this)->traceAfterDispatch(visitor);
- return;
- case ValueListClass:
- toCSSValueList(this)->traceAfterDispatch(visitor);
- return;
- case CSSTransformClass:
- toCSSTransformValue(this)->traceAfterDispatch(visitor);
- return;
- case LineBoxContainClass:
- toCSSLineBoxContainValue(this)->traceAfterDispatch(visitor);
- return;
- case CalculationClass:
- toCSSCalcValue(this)->traceAfterDispatch(visitor);
- return;
- case ImageSetClass:
- toCSSImageSetValue(this)->traceAfterDispatch(visitor);
- return;
- case CSSFilterClass:
- toCSSFilterValue(this)->traceAfterDispatch(visitor);
- return;
- }
- ASSERT_NOT_REACHED();
-}
-
PassRefPtr<CSSValue> CSSValue::cloneForCSSOM() const
{
switch (classType()) {
« no previous file with comments | « sky/engine/core/css/CSSValue.h ('k') | sky/engine/core/css/CSSValueList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698