Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Unified Diff: sky/engine/core/css/CSSGradientValue.h

Issue 723253004: Remove tons of OILPAN. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/css/CSSFunctionValue.cpp ('k') | sky/engine/core/css/CSSGradientValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/css/CSSGradientValue.h
diff --git a/sky/engine/core/css/CSSGradientValue.h b/sky/engine/core/css/CSSGradientValue.h
index 3faf51e2ace28071175cbf84a2d0a44b58db67d0..b26e3e7515d2224bc04655c016c803ec47aa9aae 100644
--- a/sky/engine/core/css/CSSGradientValue.h
+++ b/sky/engine/core/css/CSSGradientValue.h
@@ -47,11 +47,6 @@ enum CSSGradientType {
};
enum CSSGradientRepeat { NonRepeating, Repeating };
-// This struct is stack allocated and allocated as part of vectors.
-// When allocated on the stack its members are found by conservative
-// stack scanning. When allocated as part of Vectors in heap-allocated
-// objects its members are visited via the containing object's
-// (CSSGradientValue) traceAfterDispatch method.
struct CSSGradientColorStop {
ALLOW_ONLY_INLINE_ALLOCATION();
public:
@@ -65,8 +60,6 @@ public:
return compareCSSValuePtr(m_color, other.m_color)
&& compareCSSValuePtr(m_position, other.m_position);
}
-
- void trace(Visitor*);
};
} // namespace blink
@@ -106,8 +99,6 @@ public:
void loadSubimages(ResourceFetcher*) { }
PassRefPtr<CSSGradientValue> gradientWithStylesResolved(const TextLinkColors&, Color currentColor);
- void traceAfterDispatch(Visitor*);
-
protected:
CSSGradientValue(ClassType classType, CSSGradientRepeat repeat, CSSGradientType gradientType)
: CSSImageGeneratorValue(classType)
@@ -175,8 +166,6 @@ public:
bool equals(const CSSLinearGradientValue&) const;
- void traceAfterDispatch(Visitor*);
-
private:
CSSLinearGradientValue(CSSGradientRepeat repeat, CSSGradientType gradientType = CSSLinearGradient)
: CSSGradientValue(LinearGradientClass, repeat, gradientType)
@@ -222,8 +211,6 @@ public:
bool equals(const CSSRadialGradientValue&) const;
- void traceAfterDispatch(Visitor*);
-
private:
CSSRadialGradientValue(CSSGradientRepeat repeat, CSSGradientType gradientType = CSSRadialGradient)
: CSSGradientValue(RadialGradientClass, repeat, gradientType)
« no previous file with comments | « sky/engine/core/css/CSSFunctionValue.cpp ('k') | sky/engine/core/css/CSSGradientValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698