Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 723173002: Chromium FYI bot running Telemetry unit tests on Android user build. (Closed)

Created:
6 years, 1 month ago by klundberg
Modified:
6 years, 1 month ago
Reviewers:
navabi1, dtu, tonyg
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Chromium FYI bot running Telemetry unit tests on Android user build. This is the bb_run_bot change needed. BUG=384341 Committed: https://crrev.com/53bb5adf4e4c5eda50f7f8db4fb656d59e6f0f4c Cr-Commit-Position: refs/heads/master@{#304451}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/android/buildbot/bb_run_bot.py View 2 chunks +4 lines, -0 lines 1 comment Download

Messages

Total messages: 11 (3 generated)
klundberg
https://codereview.chromium.org/723173002/diff/1/build/android/buildbot/bb_run_bot.py File build/android/buildbot/bb_run_bot.py (right): https://codereview.chromium.org/723173002/diff/1/build/android/buildbot/bb_run_bot.py#newcode127 build/android/buildbot/bb_run_bot.py:127: 'telemetry_perf_unittests'] +tonyg@ Do you want to run both of ...
6 years, 1 month ago (2014-11-13 15:50:22 UTC) #2
klundberg
Associated master and slave changes are here: https://codereview.chromium.org/725663002/
6 years, 1 month ago (2014-11-13 16:18:31 UTC) #3
klundberg
Friendly ping in case this got lost in all your emails.
6 years, 1 month ago (2014-11-14 19:23:18 UTC) #4
tonyg
lgtm This is perfect! Then we can also use it to green up all the ...
6 years, 1 month ago (2014-11-14 20:44:33 UTC) #6
navabi1
lgtm
6 years, 1 month ago (2014-11-17 17:46:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723173002/1
6 years, 1 month ago (2014-11-17 18:26:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-17 19:29:32 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 19:30:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53bb5adf4e4c5eda50f7f8db4fb656d59e6f0f4c
Cr-Commit-Position: refs/heads/master@{#304451}

Powered by Google App Engine
This is Rietveld 408576698