Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 723133003: Shift URLRequest::Read API contract used by fetcher to ResourceLoader's. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated histogram comment. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « net/url_request/sdch_dictionary_fetcher.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index c3b487fc0035c912a7cfaa9b11284d53d75e2ee0..ef2f1391182732ec4f02ce79eb5450d35572a61b 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -53632,7 +53632,10 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="37" label="defunct">
DICTIONARY_PREVIOUSLY_SCHEDULED_TO_DOWNLOAD used instead
</int>
- <int value="38" label="DICTIONARY_FETCH_READ_FAILED"/>
+ <int value="38" label="DICTIONARY_FETCH_READ_FAILED-defunct">
+ Used to indicate a broken false return from URLRequest::Read(); no longer
+ checking that return value.
+ </int>
<int value="39" label="DICTIONARY_PREVIOUSLY_SCHEDULED_TO_DOWNLOAD"/>
<int value="40" label="ATTEMPT_TO_DECODE_NON_HTTP_DATA"/>
<int value="50" label="MULTIENCODING_FOR_NON_SDCH_REQUEST"/>
« no previous file with comments | « net/url_request/sdch_dictionary_fetcher.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698