tools/metrics/histograms/histograms.xml - Issue 723133003: Shift URLRequest::Read API contract used by fetcher to ResourceLoader's.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 723133003: Shift URLRequest::Read API contract used by fetcher to ResourceLoader's. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated comment. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 0ead9b4e630378f2d734b956de0ae799c0cd8cf0..9f8548dce04ee4401ba1155b8bec4ef0664835ed 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -53555,7 +53555,10 @@ To add a new entry, add it with any value and run test to compute valid value.

DICTIONARY_PREVIOUSLY_SCHEDULED_TO_DOWNLOAD used instead

</int>

- <int value="38" label="DICTIONARY_FETCH_READ_FAILED"/>

+ <int value="38" label="defunct">

Alexei Svitkine (slow) 2014/11/17 22:11:13 Nit: I'd keep the old name (so old data can be dec

Randy Smith (Not in Mondays) 2014/11/18 17:02:39 Done.

+ Used to indicate a broken false return from URLRequest::Read(); no longer

+ checking that return value.

+ </int>

« no previous file with comments | « net/url_request/sdch_dictionary_fetcher.cc ('k') | no next file » | no next file with comments »