Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Side by Side Diff: Source/modules/accessibility/AXRenderObject.cpp

Issue 723123002: Default orientation for aria scrollbars should be vertical (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/accessibility/aria-scrollbar-role-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 831 matching lines...) Expand 10 before | Expand all | Expand 10 after
842 } 842 }
843 843
844 AccessibilityOrientation AXRenderObject::orientation() const 844 AccessibilityOrientation AXRenderObject::orientation() const
845 { 845 {
846 const AtomicString& ariaOrientation = getAttribute(aria_orientationAttr); 846 const AtomicString& ariaOrientation = getAttribute(aria_orientationAttr);
847 if (equalIgnoringCase(ariaOrientation, "horizontal")) 847 if (equalIgnoringCase(ariaOrientation, "horizontal"))
848 return AccessibilityOrientationHorizontal; 848 return AccessibilityOrientationHorizontal;
849 if (equalIgnoringCase(ariaOrientation, "vertical")) 849 if (equalIgnoringCase(ariaOrientation, "vertical"))
850 return AccessibilityOrientationVertical; 850 return AccessibilityOrientationVertical;
851 851
852 if (isScrollbar())
853 return AccessibilityOrientationVertical;
854
852 return AXObject::orientation(); 855 return AXObject::orientation();
853 } 856 }
854 857
855 String AXRenderObject::text() const 858 String AXRenderObject::text() const
856 { 859 {
857 if (isPasswordFieldAndShouldHideValue()) 860 if (isPasswordFieldAndShouldHideValue())
858 return String(); 861 return String();
859 862
860 return AXNodeObject::text(); 863 return AXNodeObject::text();
861 } 864 }
(...skipping 1575 matching lines...) Expand 10 before | Expand all | Expand 10 after
2437 if (label && label->renderer()) { 2440 if (label && label->renderer()) {
2438 LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementR ect(); 2441 LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementR ect();
2439 result.unite(labelRect); 2442 result.unite(labelRect);
2440 } 2443 }
2441 } 2444 }
2442 2445
2443 return result; 2446 return result;
2444 } 2447 }
2445 2448
2446 } // namespace blink 2449 } // namespace blink
OLDNEW
« no previous file with comments | « LayoutTests/accessibility/aria-scrollbar-role-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698