Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 7231014: Merge 89183 - 2011-06-17 Julien Chaffraix <jchaffraix@webkit.org> (Closed)

Created:
9 years, 6 months ago by Julien - ping for review
Modified:
9 years, 6 months ago
Reviewers:
jchaffraix
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/782/
Visibility:
Public.

Description

Merge 89183 - 2011-06-17 Julien Chaffraix <jchaffraix@webkit.org>; Reviewed by Darin Adler. Assertion failure in SVGTextLayoutEngine constructor (!m_layoutAttributes.isEmpty()) https://bugs.webkit.org/show_bug.cgi?id=62884 * svg/custom/assert-empty-layout-attributes-expected.txt: Added. * svg/custom/assert-empty-layout-attributes.svg: Added. 2011-06-17 Julien Chaffraix <jchaffraix@webkit.org>; Reviewed by Darin Adler. Assertion failure in SVGTextLayoutEngine constructor (!m_layoutAttributes.isEmpty()) https://bugs.webkit.org/show_bug.cgi?id=62884 Test: svg/custom/assert-empty-layout-attributes.svg * rendering/svg/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Added a early return here. It is not needed to do the text layout algorithm if you don't have any layout information as your size is (0, 0) anyway. TBR=jchaffraix@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, --2 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +10 lines, -0 lines 0 comments Download
A + LayoutTests/svg/custom/assert-empty-layout-attributes.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/svg/custom/assert-empty-layout-attributes-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +14 lines, -0 lines 0 comments Download
M Source/WebCore/rendering/svg/SVGRootInlineBox.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Julien - ping for review
9 years, 6 months ago (2011-06-22 17:17:04 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698