Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 7231013: Merge 88474 - 2011-06-09 Julien Chaffraix <jchaffraix@webkit.org> (Closed)

Created:
9 years, 6 months ago by Julien - ping for review
Modified:
9 years, 6 months ago
Reviewers:
jchaffraix
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/782/
Visibility:
Public.

Description

Merge 88474 - 2011-06-09 Julien Chaffraix <jchaffraix@webkit.org>; Reviewed by Darin Adler. Test for WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash https://bugs.webkit.org/show_bug.cgi?id=62384 * fast/css/webkit-keyframes-crash-expected.txt: Added. * fast/css/webkit-keyframes-crash.html: Added. 2011-06-09 Julien Chaffraix <jchaffraix@webkit.org>; Reviewed by Darin Adler. WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash https://bugs.webkit.org/show_bug.cgi?id=62384 Test: fast/css/webkit-keyframes-crash.html * css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::setName): stylesheet() is never garanteed to return a non-null pointer. Thus null-check here like the rest of the code. TBR=jchaffraix@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89443

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, --1 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +10 lines, -0 lines 0 comments Download
A + LayoutTests/fast/css/webkit-keyframes-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/css/webkit-keyframes-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/WebCore/css/WebKitCSSKeyframesRule.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Julien - ping for review
9 years, 6 months ago (2011-06-22 17:12:15 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698