Navigation transitions (web to native app): Bug fix for hide/Show transition elements

Source/web/tests/WebDocumentTest.cpp

Index: Source/web/tests/WebDocumentTest.cpp
diff --git a/Source/web/tests/WebDocumentTest.cpp b/Source/web/tests/WebDocumentTest.cpp
index a14858f2e8d7d616e65562543c5b395b9b6bd16a..60c026564024e3d3184bce9b2b0eee832d600f91 100644
--- a/Source/web/tests/WebDocumentTest.cpp
+++ b/Source/web/tests/WebDocumentTest.cpp
@@ -101,4 +101,40 @@ TEST(WebDocumentTest, BeginExitTransition)
     ASSERT_EQ(Color(0, 128, 0), bodyStyle->visitedDependentColor(CSSPropertyColor));
 }
 
+
+TEST(WebDocumentTest, HideAndShowTransitionElements)
+{
+    std::string baseURL = "http://www.test.com:0/";
+    const char* htmlURL = "transition_hide_and_show.html";
+    URLTestHelpers::registerMockedURLLoad(toKURL(baseURL + htmlURL), WebString::fromUTF8(htmlURL));
+
+    WebViewHelper webViewHelper;
+    webViewHelper.initializeAndLoad(baseURL + htmlURL);
+
+    WebFrame* frame = webViewHelper.webView()->mainFrame();
+    Document* coreDoc = toLocalFrame(webViewHelper.webViewImpl()->page()->mainFrame())->document();
+    Element* transitionElement = coreDoc->getElementById("foo");
+    ASSERT(transitionElement);
+
+    RenderStyle* transitionStyle = transitionElement->renderStyle();
+    ASSERT(transitionStyle);
+    ASSERT_EQ(transitionStyle->opacity(), 1);

[Nate Chapin, 2014/11/13 21:29:55]

ASSERT_EQ will abort the test if the check fails. For checks that won't cause
the test to crash if they fail, you can use EXPECT_EQ to ensure you can see if
there are multiple failures.

[Zhen Wang, 2014/11/13 21:47:47]

I see. Changing to EXPECT_EQ now.

+
+    // Hide transition elements
+    frame->document().hideTransitionElements("#foo");
+    FrameTestHelpers::pumpPendingRequestsDoNotUse(frame);
+    coreDoc->updateRenderTreeIfNeeded();
+    transitionStyle = transitionElement->renderStyle();
+    ASSERT_TRUE(transitionStyle);
+    ASSERT_EQ(transitionStyle->opacity(), 0);
+
+    // Show transition elements
+    frame->document().showTransitionElements("#foo");
+    FrameTestHelpers::pumpPendingRequestsDoNotUse(frame);
+    coreDoc->updateRenderTreeIfNeeded();
+    transitionStyle = transitionElement->renderStyle();
+    ASSERT_TRUE(transitionStyle);
+    ASSERT_EQ(transitionStyle->opacity(), 1);
+}
+
 }