Navigation transitions (web to native app): Bug fix for hide/Show transition elements

Navigation transitions (web to native app): Bug fix for hide/Show transition elements

This CL fixes a bug when hiding and showing transition elements and adds the test for it.

BUG=370696
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185328

[Zhen Wang, 2014-11-13 21:12:17]

zhenw@chromium.org changed reviewers:
+ simonhatch@chromium.org

[Zhen Wang, 2014-11-13 21:12:18]

Hi Simon, can you take a look at this bug fix first? I will send to Nate to
review after you are ok with it. Thanks!

[shatch, 2014-11-13 21:20:01]

On 2014/11/13 21:12:18, Zhen Wang wrote:
> Hi Simon, can you take a look at this bug fix first? I will send to Nate to
> review after you are ok with it. Thanks!

Is this just the fix for the show/hide comment from the other review (+ tests)?
If so, seems fine.

[Zhen Wang, 2014-11-13 21:25:32]

Yes, it is. I will send it to Nate for review now.

[Zhen Wang, 2014-11-13 21:27:16]

zhenw@chromium.org changed reviewers:
+ japhet@chromium.org

[Zhen Wang, 2014-11-13 21:27:16]

Hi Nate,

This CL fixes a bug introduced in https://codereview.chromium.org/715653004/ by
mistake. I also added a test for it. Please take a look. Thanks!

Best
-Zhen

[Nate Chapin, 2014-11-13 21:29:55]

lgtm w/nit

https://codereview.chromium.org/723073003/diff/20001/Source/web/tests/WebDocu...
File Source/web/tests/WebDocumentTest.cpp (right):

https://codereview.chromium.org/723073003/diff/20001/Source/web/tests/WebDocu...
Source/web/tests/WebDocumentTest.cpp:121: ASSERT_EQ(transitionStyle->opacity(),
1);
ASSERT_EQ will abort the test if the check fails. For checks that won't cause
the test to crash if they fail, you can use EXPECT_EQ to ensure you can see if
there are multiple failures.

[Zhen Wang, 2014-11-13 21:47:47]

https://codereview.chromium.org/723073003/diff/20001/Source/web/tests/WebDocu...
File Source/web/tests/WebDocumentTest.cpp (right):

https://codereview.chromium.org/723073003/diff/20001/Source/web/tests/WebDocu...
Source/web/tests/WebDocumentTest.cpp:121: ASSERT_EQ(transitionStyle->opacity(),
1);
I see. Changing to EXPECT_EQ now.

[Nate Chapin, 2014-11-13 21:57:38]

lgtm, thanks

[Zhen Wang, 2014-11-13 22:54:40]

The CQ bit was checked by zhenw@chromium.org

[commit-bot: I haz the power, 2014-11-13 22:55:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/723073003/40001

[commit-bot: I haz the power, 2014-11-13 23:06:05]

Committed patchset #3 (id:40001) as 185328