Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 723063005: Document ownership area for rbyers, vollick and rune in core/OWNERS (Closed)

Created:
6 years, 1 month ago by Rick Byers
Modified:
6 years, 1 month ago
Reviewers:
Ian Vollick, rune
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Add a few comments to core/OWNERS We've now agreed to document areas of ownership in core/OWNERS (https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/StkI3k4Pm5U/i5PdztzMgNMJ). This adds a few descriptions of areas people gave me on a blink-core-owners-discuss thread back in May. NOTRY=True BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185379

Patch Set 1 #

Patch Set 2 : Fix typo, expand my entry a bit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/core/OWNERS View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Rick Byers
Ian, PTAL
6 years, 1 month ago (2014-11-14 16:51:55 UTC) #2
Ian Vollick
On 2014/11/14 16:51:55, Rick Byers wrote: > Ian, PTAL my bit lgtm with a nit: ...
6 years, 1 month ago (2014-11-14 16:54:23 UTC) #3
Rick Byers
On 2014/11/14 16:54:23, vollick wrote: > On 2014/11/14 16:51:55, Rick Byers wrote: > > Ian, ...
6 years, 1 month ago (2014-11-14 17:09:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723063005/20001
6 years, 1 month ago (2014-11-14 17:11:17 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 185379
6 years, 1 month ago (2014-11-14 17:11:57 UTC) #7
rune
6 years, 1 month ago (2014-11-14 21:33:46 UTC) #8
Message was sent while issue was closed.
On 2014/11/14 at 17:09:41, rbyers wrote:

> This is sufficiently trivial that I'm not going to block on review from
everyone (I already promised I'd just submit this for people to save them the
effort).  Rune, feel free to TBR me on any change you want to your comment.

lgtm

Powered by Google App Engine
This is Rietveld 408576698