Instrumented libraries: overhaul RPATH handling.

Instrumented libraries: overhaul RPATH handling.

(1) Run fix_rpaths.sh separately for each package. Previously we ran it once as
a separate build step. This was the only way when all packages were installed in
the same directory, but since we now install each package in a temporary
directory first, it makes more sense to run fix_rpaths.sh there.
(2) Also fix the one remaining package which didn't use a temp directory.
(3) As a consequence of (1), fixed an issue caused by the fix_rpaths step
sometimes failing to run (http://crbug.com/433547).
(4) Improve the DSO discovery regexp in fix_rpaths.sh. Previously it only
covered DSOs which had unversioned symlinks pointing to them.
(5) Remove an outdated RPATH entry for dependent executables
(/usr/lib/x86_64-linux-gnu/ - we don't install anything there anymore).

BUG=433547
R=glider@chromium.org
NOTRY=true

Committed: https://crrev.com/59a4c28d5e275836a5666f25bff4850215c7b481
Cr-Commit-Position: refs/heads/master@{#304459}

[earthdok, 2014-11-17 19:19:14]

ptal

the script needs a rewrite so badly

[Alexander Potapenko, 2014-11-17 19:29:00]

LGTM with two nits.

https://codereview.chromium.org/723033006/diff/1/third_party/instrumented_lib...
File third_party/instrumented_libraries/download_build_install.py (right):

https://codereview.chromium.org/723033006/diff/1/third_party/instrumented_lib...
third_party/instrumented_libraries/download_build_install.py:33:
script_absolute_path = os.path.dirname(os.path.abspath(__file__))
I think global variables are named in CAPITAL_CASE_WITH_UNDERSCORES.

https://codereview.chromium.org/723033006/diff/1/third_party/instrumented_lib...
third_party/instrumented_libraries/download_build_install.py:112:
parsed_arguments.verbose, environment)
Please fix the indentation.

[earthdok, 2014-11-17 19:44:10]

On 2014/11/17 19:29:00, Alexander Potapenko wrote:
> LGTM with two nits.
> 
>
https://codereview.chromium.org/723033006/diff/1/third_party/instrumented_lib...
> File third_party/instrumented_libraries/download_build_install.py (right):
> 
>
https://codereview.chromium.org/723033006/diff/1/third_party/instrumented_lib...
> third_party/instrumented_libraries/download_build_install.py:33:
> script_absolute_path = os.path.dirname(os.path.abspath(__file__))
> I think global variables are named in CAPITAL_CASE_WITH_UNDERSCORES.
> 
>
https://codereview.chromium.org/723033006/diff/1/third_party/instrumented_lib...
> third_party/instrumented_libraries/download_build_install.py:112:
> parsed_arguments.verbose, environment)
> Please fix the indentation.

ptal

[Alexander Potapenko, 2014-11-17 19:53:27]

LGTM

[Alexander Potapenko, 2014-11-17 19:53:30]

The CQ bit was checked by glider@chromium.org

[commit-bot: I haz the power, 2014-11-17 19:54:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/723033006/40001

[commit-bot: I haz the power, 2014-11-17 19:55:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-17 19:57:40]

Patchset 3 (id:??) landed as
https://crrev.com/59a4c28d5e275836a5666f25bff4850215c7b481
Cr-Commit-Position: refs/heads/master@{#304459}