Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 723033002: Eliminate unnecessary forward declarations from components/password_manager (Closed)

Created:
6 years, 1 month ago by Sunil Ratnu
Modified:
6 years, 1 month ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Eliminate unnecessary forward declarations from components/password_manager Some of the forward declrations are not necessary, hence, removed them. This also makes sure that we forward declare wherever there is use instead of using that declaration through another #include. BUG=432826 Committed: https://crrev.com/e101909637ac60db4ac0b44a0c722a621354c97c Cr-Commit-Position: refs/heads/master@{#304130}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -50 lines) Patch
M chrome/browser/ui/login/login_prompt.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/content/browser/credential_manager_password_form_manager.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/password_manager/content/renderer/credential_manager_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/password_manager/core/browser/login_database.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/password_manager/core/browser/mock_password_store.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/password_manager/core/browser/password_manager.h View 2 chunks +0 lines, -5 lines 0 comments Download
M components/password_manager/core/browser/password_manager_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/password_manager/core/browser/password_manager_internals_service.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/password_manager/core/browser/password_manager_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M components/password_manager/core/browser/password_store.h View 1 chunk +0 lines, -7 lines 0 comments Download
M components/password_manager/core/browser/psl_matching_helper.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/password_manager/core/browser/test_password_store.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/password_manager/core/browser/webdata/password_web_data_service_win.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Sunil Ratnu
msw@chromium.org: Please review changes in chrome/browser/ui/login/ vabr@chromium.org/isherman@chromium.org: Please review changes in components/password_manager/
6 years, 1 month ago (2014-11-13 07:14:07 UTC) #2
vabr (Chromium)
Very nice, thanks for the cleanup! Please add a tracking bug on http://crbug.com and a ...
6 years, 1 month ago (2014-11-13 08:54:11 UTC) #3
Sunil Ratnu
On 2014/11/13 08:54:11, vabr (Chromium) wrote: > Very nice, thanks for the cleanup! > > ...
6 years, 1 month ago (2014-11-13 09:01:19 UTC) #4
vabr (Chromium)
Thanks! components/password_manager/* LGTM. Cheers, Vaclav
6 years, 1 month ago (2014-11-13 09:14:09 UTC) #5
msw
lgtm
6 years, 1 month ago (2014-11-13 19:47:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723033002/1
6 years, 1 month ago (2014-11-13 22:39:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-14 00:59:40 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 00:59:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e101909637ac60db4ac0b44a0c722a621354c97c
Cr-Commit-Position: refs/heads/master@{#304130}

Powered by Google App Engine
This is Rietveld 408576698