Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 723023002: Reland "[turbofan] Weakening of types must weaken ranges inside unions." (Closed)

Created:
6 years, 1 month ago by Jarin
Modified:
6 years, 1 month ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Reland "[turbofan] Weakening of types must weaken ranges inside unions." This relands commit 4c1f4b796d1c455fc6a023abe145a5e48c4b7b1f. R=rossberg@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/2d075e22985f69d775f2a47a77b37e4babb19ffd

Patch Set 1 #

Patch Set 2 : Remove monotonicity test (monotonicity does not hold) #

Patch Set 3 : Get rid of RangeTypeToHandle helper #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -11 lines) Patch
M src/compiler/typer.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M src/types.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/types.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M test/cctest/test-types.cc View 1 2 2 chunks +33 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-weakening-multiplication.js View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jarin
Could you take a look, please? Unfortunately, GetRange is not really monotone, so I removed ...
6 years, 1 month ago (2014-11-13 07:51:49 UTC) #1
rossberg
LGTM > Unfortunately, GetRange is not really monotone, so I removed the test. > > ...
6 years, 1 month ago (2014-11-13 08:05:14 UTC) #2
Jarin
6 years, 1 month ago (2014-11-13 09:02:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
2d075e22985f69d775f2a47a77b37e4babb19ffd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698