Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 723013003: IDL: Improve overload resolution for methods with variadic arguments (Closed)

Created:
6 years, 1 month ago by Jens Widell
Modified:
6 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Improve overload resolution for methods with variadic arguments When calculating "optionality list" for a method (as part of calculating the effective overload set), treat variadic arguments as optional instead as required. WebIDL defines the optionality list as a list of "required", "optional" and "variadic", whereas we implement it as a list of booleans. A list of booleans is enough to achieve correct behavior, assuming both "optional" and "variadic" are considered to be optional (true). BUG=293561 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185289

Patch Set 1 : add test #

Patch Set 2 : the fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -2 lines) Patch
M Source/bindings/scripts/v8_interface.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M Source/bindings/scripts/v8_methods.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/idls/core/TestObject.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 1 2 chunks +75 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Jens Widell
PTAL
6 years, 1 month ago (2014-11-13 09:31:15 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-11-13 09:33:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723013003/20001
6 years, 1 month ago (2014-11-13 09:36:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/36294)
6 years, 1 month ago (2014-11-13 11:45:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723013003/20001
6 years, 1 month ago (2014-11-13 11:51:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/36318)
6 years, 1 month ago (2014-11-13 13:40:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723013003/20001
6 years, 1 month ago (2014-11-13 13:41:57 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 14:17:05 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 185289

Powered by Google App Engine
This is Rietveld 408576698