add file:// handling to mac and linux builds

add file:// handling to mac and linux builds

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3232

[Amanda Walker, 2008-10-10 15:49:34]

LGTM

[darin (slow to review), 2008-10-10 16:28:11]

http://codereview.chromium.org/7230/diff/1/5
File net/url_request/url_request_file_job.cc (right):

http://codereview.chromium.org/7230/diff/1/5#newcode109
Line 109: #if defined(OS_WIN)
You should probably include the compare call in this #ifdef.  I would just put a
return after the WorkerPool::PostTask call.  that way you can drop the else, and
then have everything else just live outside of the #ifdef.

[pink (ping after 24hrs), 2008-10-10 16:43:52]

http://codereview.chromium.org/7230/diff/1/5
File net/url_request/url_request_file_job.cc (right):

http://codereview.chromium.org/7230/diff/1/5#newcode109
Line 109: #if defined(OS_WIN)
On 2008/10/10 16:28:11, darin wrote:
> You should probably include the compare call in this #ifdef.  I would just put
a
> return after the WorkerPool::PostTask call.  that way you can drop the else,
and
> then have everything else just live outside of the #ifdef.

Done.

[Evan Martin, 2008-10-10 19:04:35]

Works on Linux.