chrome/browser/history/download_database.cc - Issue 722953002: downloads: add the ability to undo download removal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/download_database.cc

Issue 722953002: downloads: add the ability to undo download removal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/downloads/downloads_api.cc ('K') | « chrome/browser/extensions/api/downloads/downloads_api.cc ('k') | chrome/browser/resources/downloads/compiled_resources.gyp » ('j') | chrome/browser/resources/downloads/downloads.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/download_database.cc

diff --git a/chrome/browser/history/download_database.cc b/chrome/browser/history/download_database.cc

index 9461e4523f8689253c107e0482f42d289305f7d7..9dee6edb941b5d3c41a8d5f2c31b15f081342e1a 100644

--- a/chrome/browser/history/download_database.cc

+++ b/chrome/browser/history/download_database.cc

@@ -95,6 +95,7 @@ int DownloadDatabase::StateToInt(DownloadItem::DownloadState state) {

case DownloadItem::COMPLETE: return DownloadDatabase::kStateComplete;

case DownloadItem::CANCELLED: return DownloadDatabase::kStateCancelled;

case DownloadItem::INTERRUPTED: return DownloadDatabase::kStateInterrupted;

+ case DownloadItem::REMOVED:

benjhayden 2014/11/13 18:01:59 How do you ensure that this isn't reached?

case DownloadItem::MAX_DOWNLOAD_STATE:

NOTREACHED();

return DownloadDatabase::kStateInvalid;