chrome/browser/download/download_item_model.cc - Issue 722953002: downloads: add the ability to undo download removal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_item_model.cc

Issue 722953002: downloads: add the ability to undo download removal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: whoops Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/download/download_path_reservation_tracker.cc » ('j') | chrome/browser/download/download_path_reservation_tracker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_item_model.cc

diff --git a/chrome/browser/download/download_item_model.cc b/chrome/browser/download/download_item_model.cc

index f1ef10f5bcfbf2dc4d54c27888feb39e1a25f73e..7f74d0064663673c0e088ea727b4cb85b1b814b7 100644

--- a/chrome/browser/download/download_item_model.cc

+++ b/chrome/browser/download/download_item_model.cc

@@ -533,6 +533,7 @@ bool DownloadItemModel::ShouldRemoveFromShelfWhenComplete() const {

// Interrupted or cancelled downloads should remain on the shelf.

return false;

+ case DownloadItem::REMOVED:

Dan Beam 2014/11/13 02:51:16 not really sure what to do here...

case DownloadItem::MAX_DOWNLOAD_STATE:

NOTREACHED();

}

« no previous file with comments | « no previous file | chrome/browser/download/download_path_reservation_tracker.cc » ('j') | chrome/browser/download/download_path_reservation_tracker.cc » ('J')