content/browser/download/download_item_impl.cc - Issue 722953002: downloads: add the ability to undo download removal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_item_impl.cc

Issue 722953002: downloads: add the ability to undo download removal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dcheck Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/downloads_dom_handler.cc ('k') | content/browser/download/download_manager_impl.h » ('j') | content/browser/download/download_manager_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/download_item_impl.cc

diff --git a/content/browser/download/download_item_impl.cc b/content/browser/download/download_item_impl.cc

index f681486cdcbe4ee660ad38d5378f7a584db242c2..9dc2e332423933cb6c10ec871ef328a23d8c2c5c 100644

--- a/content/browser/download/download_item_impl.cc

+++ b/content/browser/download/download_item_impl.cc

@@ -341,7 +341,6 @@ void DownloadItemImpl::StealDangerousDownload(

}

current_path_.clear();

Remove();

- // We have now been deleted.

benjhayden 2014/11/21 00:50:00 I found these comments helpful. Why remove them?

Dan Beam 2014/11/21 05:32:21 because (with this change) they're no longer corre

}

void DownloadItemImpl::Pause() {

@@ -443,7 +442,6 @@ void DownloadItemImpl::Remove() {

NotifyRemoved();

delegate_->DownloadRemoved(this);

- // We have now been deleted.

}

void DownloadItemImpl::OpenDownload() {