Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 722943002: Cleanup: Delete SkFlattenableBuffers header. (Closed)

Created:
6 years, 1 month ago by tfarina
Modified:
6 years, 1 month ago
Reviewers:
hal.canary, reed1
CC:
reviews_skia.org, hal.canary, bsalomon
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Cleanup: Delete SkFlattenableBuffers header. It is empty. cs.chromium.org shows no one is including it. BUG=skia:3108 R=reed@google.com Committed: https://skia.googlesource.com/skia/+/8816e7bfbe38e0ae9bf2d9879298c1965c2ff171

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
D include/core/SkFlattenableBuffers.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
tfarina
6 years, 1 month ago (2014-11-13 02:22:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722943002/1
6 years, 1 month ago (2014-11-13 02:23:15 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-13 02:23:16 UTC) #4
commit-bot: I haz the power
Presubmit check for 722943002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 1 month ago (2014-11-13 02:23:19 UTC) #6
hal.canary
lgtm I was waiting for http://crrev.com/478383002 to land, and then I was distracted by other ...
6 years, 1 month ago (2014-11-13 02:29:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722943002/1
6 years, 1 month ago (2014-11-13 14:49:06 UTC) #10
commit-bot: I haz the power
Presubmit check for 722943002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 1 month ago (2014-11-13 14:49:10 UTC) #12
reed1
lgtm
6 years, 1 month ago (2014-11-13 18:34:58 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722943002/1
6 years, 1 month ago (2014-11-13 18:35:18 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/657)
6 years, 1 month ago (2014-11-13 18:51:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722943002/1
6 years, 1 month ago (2014-11-13 22:42:20 UTC) #19
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 22:50:05 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8816e7bfbe38e0ae9bf2d9879298c1965c2ff171

Powered by Google App Engine
This is Rietveld 408576698