Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 722913002: Make test_sky output to (e.g.) out/Debug/layout-test-results instead of webkit/Debug/layout-test-re… (Closed)

Created:
6 years, 1 month ago by viettrungluu
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Make test_sky output to (e.g.) out/Debug/layout-test-results instead of webkit/Debug/layout-test-results. Also remove webkit/{Debug,Release} from the .gitignore. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b69797809efc1937a5b340534bf8092cd7528a63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M .gitignore View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/tools/webkitpy/layout_tests/port/base.py View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
viettrungluu
6 years, 1 month ago (2014-11-13 00:43:32 UTC) #1
abarth-chromium
lgtm
6 years, 1 month ago (2014-11-13 00:53:46 UTC) #3
viettrungluu
6 years, 1 month ago (2014-11-13 00:55:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b69797809efc1937a5b340534bf8092cd7528a63 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698