Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 722893002: Use "unsigned" rather than "unsigned long" for C++ code interacting with WebIDL's "unsigned long". (Closed)

Created:
6 years, 1 month ago by eroman
Modified:
6 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Use "unsigned" rather than "unsigned long" for C++ code interacting with WebIDL's "unsigned long". (WebIDL's "unsigned long" is a 32-bit type) BUG=267360 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185261

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/core/xml/XPathResult.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/xml/XPathResult.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
eroman
6 years, 1 month ago (2014-11-12 23:39:00 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-11-12 23:52:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722893002/1
6 years, 1 month ago (2014-11-13 00:38:17 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 02:15:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185261

Powered by Google App Engine
This is Rietveld 408576698