Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 722873004: Revert "TransitionArray now uses <is_data_property, name, attributes> tuple as a key, which allows … (Closed)

Created:
6 years, 1 month ago by Igor Sheludko
Modified:
6 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Revert "TransitionArray now uses <is_data_property, name, attributes> tuple as a key, which allows to have several entries for the same property name." Revert "Fix for an assertion failure in Map::FindTransitionToField(...). Appeared after r25136." This revert is made in order to revert r25099 which potentially causes renderer hangs. R=verwaest@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/2e38f3391116d87ec3745982b24a0279dcefe2d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -598 lines) Patch
M src/globals.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 5 chunks +4 lines, -14 lines 0 comments Download
M src/objects.cc View 19 chunks +53 lines, -55 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +16 lines, -27 lines 0 comments Download
M src/objects-inl.h View 5 chunks +12 lines, -34 lines 0 comments Download
M src/objects-printer.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/transitions.h View 3 chunks +2 lines, -39 lines 0 comments Download
M src/transitions.cc View 5 chunks +5 lines, -57 lines 0 comments Download
M src/transitions-inl.h View 3 chunks +2 lines, -67 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/test-transitions.cc View 1 chunk +0 lines, -283 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-430846.js View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Igor Sheludko
PTAL
6 years, 1 month ago (2014-11-13 13:30:35 UTC) #2
Toon Verwaest
rubberstamp lgtm
6 years, 1 month ago (2014-11-13 13:39:21 UTC) #3
Igor Sheludko
6 years, 1 month ago (2014-11-13 15:31:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2e38f3391116d87ec3745982b24a0279dcefe2d7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698