gpu/command_buffer/service/gles2_cmd_decoder.h - Issue 722823002: gpu: Make sure sync queries complete on service side when calling glFinish.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.h

Issue 722823002: gpu: Make sure sync queries complete on service side when calling glFinish. Base URL: https://chromium.googlesource.com/chromium/src.git@2214

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/command_buffer/service/gles2_cmd_decoder.h

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.h b/gpu/command_buffer/service/gles2_cmd_decoder.h

index 8d72335f7febf31488246b22aeebb540336ed7be..63618c2a2da03724e96efc202f940c6c9b40de36 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder.h

+++ b/gpu/command_buffer/service/gles2_cmd_decoder.h

@@ -171,7 +171,7 @@ class GPU_EXPORT GLES2Decoder : public base::SupportsWeakPtr<GLES2Decoder>,

virtual ImageManager* GetImageManager() = 0;

// Process any pending queries. Returns false if there are no pending queries.

- virtual bool ProcessPendingQueries() = 0;

+ virtual bool ProcessPendingQueries(bool did_finish) = 0;

// Returns false if there are no idle work to be made.

virtual bool HasMoreIdleWork() = 0;

« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »