Classes: Implement correct name binding

src/ast.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_AST_H_
 #define V8_AST_H_
 
 #include "src/v8.h"
 
 #include "src/assembler.h"
@@ skipping 2653 matching lines @@
 
 
 class ClassLiteral FINAL : public Expression {
  public:
   typedef ObjectLiteralProperty Property;
 
   DECLARE_NODE_TYPE(ClassLiteral)
 
   Handle<String> name() const { return raw_name_->string(); }
   const AstRawString* raw_name() const { return raw_name_; }
+  Scope* scope() const { return scope_; }
+  VariableProxy* proxy() const { return proxy_; }

[Dmitry Lomov (no reviews), 2014/11/13 11:17:37]

Nit: rename proxy => class_variable_proxy (also field)

"Proxy" is way overloaded.

[arv (Not doing code reviews), 2014/11/13 20:47:49]

Done.

   Expression* extends() const { return extends_; }
   Expression* constructor() const { return constructor_; }
   ZoneList<Property*>* properties() const { return properties_; }
   int start_position() const { return position(); }
   int end_position() const { return end_position_; }
 
  protected:
-  ClassLiteral(Zone* zone, const AstRawString* name, Expression* extends,
+  ClassLiteral(Zone* zone, const AstRawString* name, Scope* scope,
+               VariableProxy* proxy, Expression* extends,

[Dmitry Lomov (no reviews), 2014/11/13 11:17:37]

proxy => class_variable_proxy

[arv (Not doing code reviews), 2014/11/13 20:47:49]

Done.

                Expression* constructor, ZoneList<Property*>* properties,
                int start_position, int end_position)
       : Expression(zone, start_position),
         raw_name_(name),
+        scope_(scope),
+        proxy_(proxy),
         extends_(extends),
         constructor_(constructor),
         properties_(properties),
         end_position_(end_position) {}
 
  private:
   const AstRawString* raw_name_;
+  Scope* scope_;
+  VariableProxy* proxy_;

[Dmitry Lomov (no reviews), 2014/11/13 11:17:37]

proxy_ => class_variable_proxy_

[arv (Not doing code reviews), 2014/11/13 20:47:49]

Done.

   Expression* extends_;
   Expression* constructor_;
   ZoneList<Property*>* properties_;
   int end_position_;
 };
 
 
 class NativeFunctionLiteral FINAL : public Expression {
  public:
   DECLARE_NODE_TYPE(NativeFunctionLiteral)
@@ skipping 963 matching lines @@
         expected_property_count, handler_count, parameter_count, function_type,
         has_duplicate_parameters, is_function, is_parenthesized, kind,
         position);
     // Top-level literal doesn't count for the AST's properties.
     if (is_function == FunctionLiteral::kIsFunction) {
       visitor_.VisitFunctionLiteral(lit);
     }
     return lit;
   }
 
-  ClassLiteral* NewClassLiteral(const AstRawString* name, Expression* extends,
+  ClassLiteral* NewClassLiteral(const AstRawString* name, Scope* scope,
+                                VariableProxy* proxy, Expression* extends,

[Dmitry Lomov (no reviews), 2014/11/13 11:17:37]

proxy => class_variable_proxy

                                 Expression* constructor,
                                 ZoneList<ObjectLiteral::Property*>* properties,
                                 int start_position, int end_position) {
-    ClassLiteral* lit =
-        new (zone_) ClassLiteral(zone_, name, extends, constructor, properties,
-                                 start_position, end_position);
+    ClassLiteral* lit = new (zone_)
+        ClassLiteral(zone_, name, scope, proxy, extends, constructor,
+                     properties, start_position, end_position);
     VISIT_AND_RETURN(ClassLiteral, lit)
   }
 
   NativeFunctionLiteral* NewNativeFunctionLiteral(const AstRawString* name,
                                                   v8::Extension* extension,
                                                   int pos) {
     NativeFunctionLiteral* lit =
         new (zone_) NativeFunctionLiteral(zone_, name, extension, pos);
     VISIT_AND_RETURN(NativeFunctionLiteral, lit)
   }
@@ skipping 13 matching lines @@
  private:
   Zone* zone_;
   Visitor visitor_;
   AstValueFactory* ast_value_factory_;
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_AST_H_